feat(telemetry): maintain public vocabulary from stable releases - #29
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed October 1, 2026, 3:21 AM ET / 07:21 UTC (Revision 2). ClawSweeper reviewWhat this changesAdd daily stable-release discovery, historical vocabulary backfill, validated data-only publication, and exact-commit deployment verification to telemetry’s existing workflow. Merge readiness⛔ Blocked before merge - 4 items remain This remains distinct from the merged vocabulary repairs and has no identified blocking code defect. The daily schedule preserves the unresolved decision to authorize automatic publication and production deployment; the author’s MEMBER association also prevents automatic closure. Priority: P2 Review scores
Verification
How this fits togetherTelemetry filters reported feature names through a compiled public vocabulary before recording analytics. This workflow derives that vocabulary from released OpenClaw metadata, publishes validated updates, and deploys the Worker. flowchart LR
A[Stable OpenClaw releases] --> B[Daily release discovery]
B --> C[Isolated vocabulary generation]
C --> D[Trusted artifact validation]
D --> E[Data-only publication]
E --> F[Worker deployment]
F --> G[Exact-commit rollout receipt]
Decision needed
Why: This grants recurring operational authority, and the PR explicitly reserves activation for separate review; changing cadence does not establish approval. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Adopt automatic maintenance through an explicitly approved rollout that preserves manual recovery and verifies data-only publication and exact-commit deployment. Do we have a high-confidence way to reproduce the issue? Not applicable to a proposed automation capability. Source confirms that main still relies on manual refresh and lacks this scheduled publication path. Is this the best way to solve the issue? Yes, extending the existing generator and deployment workflow avoids a competing implementation; operational adoption still needs explicit approval. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 6a440445c2e2. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
|
Daily activation is approved and landed as 133ff8562f721cbe3cea3683523e058afae6e0ac: the 03:17 UTC release poll, validated data-only publication, and the existing production deployment path use the documented released-generator trust boundary. Fresh Astra/high autoreview of the complete main-to-head diff at Post-merge verification:
ClawSweeper rank-up disposition: live generated-change publication awaits a real new stable release; we did not fabricate released source, ingestion traffic, or a production failure merely to exercise it. This operational uncertainty is accepted. Deterministic tests cover publication races and failed/missing receipt retries. The first real scheduled execution remains future; manual recovery is not evidence of the scheduled trigger itself. |
Problem and result
Public vocabulary drift previously required a maintainer to regenerate, commit, and deploy names for each OpenClaw release. Build on #27 and #28 by putting that recurring work in the existing Deploy workflow.
Fully paginate stable releases, retain immutable release/tag/commit identities, backfill missed snapshots, and keep historical public names. Generation runs read-only; a separate trusted check job validates the two generated files and runs the existing tests and build. A constrained publisher can fast-forward only those files. The existing deployment job then verifies one 100%-active Worker version tagged with the exact checked commit. Missing or failed deployment receipts remain retryable even when publication already succeeded.
Activation and trust boundary
Draft only. Merging this workflow would enable daily generation at 03:17 UTC, automatic data-only publication to main, and deployment. That operational activation needs separate review and discussion. Nothing has been scheduled, dispatched, deployed, or configured by this PR publication.
v2026.9.7; earlier retained catalog history is broader but does not prove every transient older bundled name. Freshness can lag until the next daily run, plus GitHub scheduler and queue delays. Manual recovery remains available. Changed contracts, moved tags, byte-budget growth, and publication-policy failures still need maintainer review.Evidence
3a2b7eeb3470f974dc0dfbe19da158fe4baef6a2: typecheck, all 14 test files, release coverage, and Wrangler dry-run. CodeQL also passed. Discovery, generation, publication, and deployment jobs were skipped. No live end-to-end automation or deployment test was run.Production scripts: +262/-2 (net +260); workflow: +175/-3 (net +172); tests: +205/-1 (net +204). The growth implements release completeness/provenance, the data-only publication boundary, concurrency, and rollout recovery. Worker runtime code, dependencies, stored columns, and the current vocabulary are unchanged.
The daily-cadence update at
39440071640f06323b6f377f0eb2f1e2ac145166changes only the scheduled cron and matching documentation (+6/-6 across three files). Actionlint, diff checks, and independent delta review pass. Fresh exact-head PR CI passes on this daily-cadence head, including the normal check, release coverage, and Wrangler dry-run. CodeQL passes; discovery, generation, publication, and deployment are skipped. Historical CI above remains attributed to its original head.