Ship a cross-desktop ignoreApps default - #62
Open
toxicphreAK wants to merge 2 commits into
Open
Conversation
The shipped config blocked only KDE components from triggering a hydration, so on GNOME, Cinnamon, MATE or Xfce nothing was blocked at all: nautilus and its thumbnailer helpers, tracker/localsearch, gvfsd and the shell search providers open dehydrated files as a matter of routine. Browsing a folder downloaded everything in it and indexing downloaded the entire sync root -- silently, and on what is probably the most common Linux desktop. The list now covers the common file managers, the freedesktop thumbnailer convention (a "thumbnailer" suffix catches the -thumbnailer binaries and ffmpegthumbnailer alike), the GNOME/tracker and localsearch indexers, gvfs helpers, locate's updatedb and ClamAV. /usr/bin/dolphin moved from byName to an endsWith entry: matching the binary name rather than an absolute path holds across distributions that install elsewhere. This is a starting point rather than an exhaustive list -- see INTEGRATION.md. Enumerating every indexer, thumbnailer and antivirus in existence does not converge, so a permit-list of the few applications that should be allowed to trigger a download may scale better; that is a design decision for the maintainers and is deliberately not attempted here. The errno returned to a blocked caller is likewise left at EPERM.
toxicphreAK
force-pushed
the
split/ignore-apps
branch
from
August 27, 2026 09:06
9420dc6 to
a21947c
Compare
mgallien
approved these changes
Aug 27, 2026
mgallien
left a comment
mgallien
left a comment
Collaborator
There was a problem hiding this comment.
thanks
was planning to do it
dragotin
approved these changes
Sep 2, 2026
dragotin
left a comment
dragotin
left a comment
Member
There was a problem hiding this comment.
Great, thanks for finding all these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #54.
The shipped
ignoreAppslist was KDE-only, so on GNOME/Cinnamon/MATE/Xfce nothing was blocked: browsing a folder downloaded everything in it, indexing downloaded the sync root.Now covers the common file managers, the freedesktop thumbnailer convention, tracker/localsearch, gvfs helpers,
updatedband ClamAV./usr/bin/dolphinmoved frombyNameto anendsWithentry so it holds across distributions.Two things I left alone on purpose:
EPERM. WhetherENODATAor serving placeholder content behaves better across thumbnailers has real tradeoffs.The GNOME entries are checked against a live install (all four
/usr/share/thumbnailersentries covered, includinggnome-thumbnail-font, which doesn't match the-thumbnailerconvention). KDE, Xfce, Cinnamon and MATE are from documentation and unverified — worth a second pair of eyes from someone running those.Related: #59, #52.