Repository navigation
Keep the Homebrew cask's layout and version template when bumping it - #106
Open
leoisadev1 wants to merge 1 commit into
Open
leoisadev1 wants to merge 1 commit into
leoisadev1 wants to merge 1 commit into
Conversation
The bump's line patterns ended in \s* under re.M, so replacing the sha256 line also ate the blank line after it, and a GitHub release url was written out with the literal version. brew style rejects both, which fails the macOS CI job. The bump now changes only the version and sha256 lines, and Casks/convt.rb is back in its template form at 0.3.0. Refs CNV-63
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release bot's 0.3.0 cask bump (5763e6c) dropped the blank line after
sha256and wrote the url with a literalv0.3.0.brew stylerejects that (Cask/StanzaGrouping), so the "Rust (macOS, core)" CI job now fails on every PR that includesmain. The bump's patterns ended in\s*underre.M, which also matches the newline and the blank line after. They now stop at the end of the line, and a GitHub release url keeps#{version}.Evidence
brew stylewith "stanza groups should be separated by a single empty line".After: Run on the original 0.2.0 cask with the 0.3.0 manifest values, the fixed bump produces exactly the restored
Casks/convt.rb.test_bump_changes_only_the_version_and_sha_linesandtest_a_github_release_url_keeps_its_version_templatefail on the old script and pass now. All 44 release-script tests pass.brew styleitself only runs on macOS, so the macOS CI job on this PR is the check for it.Merge Danger
Door: two-way. It changes a release script and the cask file; nothing is published by merging. The next release's bump uses the fixed script.
Blast radius: the Homebrew cask and its bump in the release workflow.
Fixes CNV-63
Created with Claude Opus 5.5 in Claude Code.