Repository navigation
Redesign /download as a get-the-app install guide - #20
leoisadev1 wants to merge 5 commits into
Conversation
| function DownloadPage() { | ||
| const { os, release } = Route.useLoaderData(); | ||
| const published = release.slots.some((s) => s.artifact); | ||
| const primary = os ? release.slots.find((s) => s.os === os) : undefined; |
There was a problem hiding this comment.
🟡 Available builds receive a coming-soon button
When a release lacks its expected first format, primary selects the empty slot despite published alternatives. The main button says “Coming soon,” and InstallGuide describes an unavailable format.
Learn more
The release model creates expected slots even when their artifacts are absent. The first slot for Linux is AppImage, and the first for Windows is MSI in releaseFromManifest and releaseFromManifest. The page uses that first slot as both the primary button and the kind passed to the install guide. If another format is published, the page still has a valid download, but its prominent action cannot access it.
Example: A ready release contains a Windows .exe but no .msi. The main Windows button says “Coming soon,” while the executable appears only under “Also”; the guide still describes the MSI-oriented flow.
Recommended fix: Pick the first slot with a published artifact for the selected OS, falling back to the expected first slot only when none is published. Keep the displayed format and install guide aligned with that selected artifact.
Was this helpful? React with 👍 or 👎 to provide feedback.
| {extras.map((slot, index) => { | ||
| const artifact = slot.artifact; | ||
| if (!artifact) return null; | ||
| return ( | ||
| <span key={slot.kind}> | ||
| {index > 0 && ", "} | ||
| <TextLink href={artifact.url} className="font-normal"> | ||
| {kindLabels[slot.kind].title} | ||
| </TextLink> |
There was a problem hiding this comment.
🟡 Alternative Linux downloads show AppImage steps
When a visitor downloads a Linux .deb, .rpm, or tarball through extras, InstallGuide still receives the AppImage primary.kind. The displayed steps tell them to run an AppImage instead of installing their chosen package.
Learn more
The first Linux slot is AppImage even when other formats are published, as defined by releaseFromManifest. The alternative links here navigate directly to artifact URLs. They never record which format the visitor downloaded, while the guide uses primary.kind. Thus the dedicated .deb, .rpm, and tarball branches of installSteps cannot be reached by visitors downloading those formats.
Example: A visitor clicks “Debian package (.deb)” under “Also”. Their browser downloads a .deb, but the page says to make an AppImage executable and double-click it.
Recommended fix: Route each alternate format through a page state or kind query parameter that selects that artifact and its matching guide before the download, or offer format-specific instructions alongside each alternative. Preserve direct download access.
Was this helpful? React with 👍 or 👎 to provide feedback.
| title: "Follow the installer", | ||
| body: "It puts convt on this computer and adds the right-click menu.", |
There was a problem hiding this comment.
🟡 Install guide promises unavailable integrations
The Windows installSteps claims MSI installation adds a right-click menu, but the installer adds no Explorer integration. Mac dragging likewise never places the bundled convt command on PATH.
Learn more
The install guide describes features as present after completing its steps. The Windows installer contains only the payload and Start menu shortcut; Windows packaging identifies Explorer integration as future work. On macOS, the bundle layout puts the CLI inside convt.app/Contents/MacOS, but the DMG only copies the app and adds a link to Applications. The steps do not make that binary available as convt in a shell.
Example: Someone installs the MSI and right-clicks a file; there is no convt Explorer action. Someone drags the Mac app to Applications and types convt in a terminal; no command is found unless they manually configure PATH or a symlink.
Recommended fix: Describe only installed integrations, or implement the Explorer integration and a documented CLI PATH setup. Update the Mac step separately to show how to invoke or expose the bundled CLI.
Was this helpful? React with 👍 or 👎 to provide feedback.
| | `content/openapi.placeholder.json` | `/docs/api` | Used only while `src/generated/openapi.json` is missing; the page then says the API is a preview. | | ||
|
|
||
| The release manifest is optional. Without it, or while its `distribution_ready` is false, every download and the source archive show "Coming soon" and nothing is linked. With it, the page lists the newest build's artifacts by platform and kind, and keeps the expected slots (macOS `dmg`, Windows `exe`, Linux `AppImage`, `deb`, `rpm`, `tar.gz`) that the build lacks as "Coming soon". | ||
| The release manifest is optional. Without it, or while its `distribution_ready` is false, the primary download for each OS shows "Coming soon" and nothing is linked. With it, the page offers the newest build for the visitor's OS and keeps missing expected slots (macOS `dmg`, Windows `msi`, Linux `AppImage`, `deb`, `rpm`, `tar.gz`) as "Coming soon". |
There was a problem hiding this comment.
|
| }, | ||
| { | ||
| title: "Follow the installer", | ||
| body: "It puts convt on this computer and adds the right-click menu.", |
There was a problem hiding this comment.
The guide says the Windows installer adds a right-click menu, but the current MSI only installs the files and a Start menu shortcut. Explorer integration is still separate work. Remove this promise until the installer actually adds it, so users do not look for a menu that is not there.
Correctness confidence: 5/5.
| body: "It puts convt on this computer and adds the right-click menu.", | |
| body: "It puts convt on this computer and adds a Start menu shortcut.", |
13ea992 to
7f2c169
Compare
3549505 to
d318596
Compare
The page now leads with the detected OS download and quiet links for the others, then three install steps for that OS. Checksums and the AGPL source block are gone; missing builds still show Coming soon in the same layout. Co-authored-by: Leo <leoisadev1@users.noreply.github.com>
…build FolderGlyph x/y are numbers; passing strings failed `tsc`. The download page now leads with a published artifact for the visitor's OS, so a Linux AppImage in the GitHub latest manifest is the primary button instead of an empty Coming soon slot. Co-authored-by: Leo <leoisadev1@users.noreply.github.com>
Rust (Linux, core) failed in renamed_binary_uses_convt_in_help_and_errors while copying the CLI binary. This PR only changes the website download page; the same job passed on the sibling PRs. Co-authored-by: Leo <leoisadev1@users.noreply.github.com>
Zip builds get archive steps and pictures instead of dmg/msi copy. Also links set ?kind= so Linux .deb/.rpm/.tar.gz show matching steps. Windows MSI promises a Start menu shortcut only; archives launch ./convt-app and no longer invent a menu helper. Published downloads show the processor (Apple silicon, 64-bit) next to the file kind. Co-authored-by: Leo <leoisadev1@users.noreply.github.com>
d318596 to
23f2ce2
Compare
Co-authored-by: Leo <leoisadev1@users.noreply.github.com>
| }, | ||
| { | ||
| title: "Install the package", | ||
| body: "Confirm the install. You can also run sudo dpkg -i on the file.", |
There was a problem hiding this comment.
Terminal installs miss required libraries
If a required graphics or desktop library is missing, the suggested dpkg -i and rpm -i commands cannot finish the install because they do not fetch it. Debian can leave the package unconfigured; RPM refuses the install. The same concern applies to the RPM step below.
Use sudo apt install ./file.deb and sudo dnf install ./file.rpm or sudo zypper install ./file.rpm instead.
Correctness confidence: 5/5.
/downloadis now an install guide instead of an inventory grid.What this does
Download for Linux/ macOS / Windows) from the latest GitHub release manifest?kind=); missing extras are hiddenReview fixes
Rebased onto current
main(including #59 Shipping today chips) and addressed every Greptile finding:?kind=selects.deb/.rpm/.tar.gz/ zip and updates both the steps and pictures./convt-app(desktop app), not theconvtCLI; no invented Linux menu helper (menus ship with deb/rpm)Install guide
macOS (disk image, Apple silicon; Also zip):
macOS install guide
macOS zip (unpack steps, not dmg copy):
macOS zip install guide
Windows (MSI, 64-bit, Start menu shortcut only):
Windows install guide
Linux AppImage (Also deb / rpm / tar.gz):
Linux AppImage install guide
Linux .deb (Also switches the steps and pictures):
Linux deb install guide
Linux mobile (390px):
Linux install guide on a phone-width viewport
To show artifacts inline, enable in settings.