Repository navigation
Correct the OpenAPI spec for Blume and redesign the dashboard API pages #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leoisadev1
wants to merge
8
commits into
main
Choose a base branch
from
cursor/api-docs-redesign-9551
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,711
−1,016
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9f742d9
api: document every error, limit and field in the OpenAPI spec
cursoragent d99c055
web: add the shared code panel and API samples for the dashboard
cursoragent 1d2b891
web: redesign the dashboard API keys and cloud converter pages
cursoragent 9304188
web: test the API reference against the spec
cursoragent 9a21a53
web: fix dashboard API labels found in the end-to-end run
cursoragent 3c55cbe
docs: retarget the overlay at the spec's components and check every t…
cursoragent dd47d06
web: point the dashboard at the Blume docs and drop the retired refer…
cursoragent 5fe7438
web: keep the committed route tree
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // Fails the build when an action in openapi/public.yaml targets nothing in the spec. | ||
| // Blume skips unmatched targets silently, so a spec refactor (an inline schema moving | ||
| // to components, say) would otherwise drop the overlay's prose without a warning. | ||
| // Targets are plain paths: `$`, `.name` and `['name']`. Wildcards and filters are | ||
| // refused because they can match nothing without being wrong. | ||
|
|
||
| const spec = await Bun.file( | ||
| new URL("../../../crates/convt-server/openapi.json", import.meta.url), | ||
| ).json(); | ||
| const overlay = Bun.YAML.parse( | ||
| await Bun.file(new URL("../openapi/public.yaml", import.meta.url)).text(), | ||
| ) as { actions: { target: string }[] }; | ||
|
|
||
| const segment = /\.([A-Za-z_$][\w$-]*)|\['([^']+)'\]/y; | ||
|
|
||
| function resolve(target: string): unknown { | ||
| if (!target.startsWith("$")) throw new Error(`${target}: targets start with $`); | ||
| let value: unknown = spec; | ||
| segment.lastIndex = 1; | ||
| while (segment.lastIndex < target.length) { | ||
| const at = segment.lastIndex; | ||
| const match = segment.exec(target); | ||
| if (!match) throw new Error(`${target}: unsupported syntax at "${target.slice(at)}"`); | ||
| value = (value as Record<string, unknown> | undefined)?.[match[1] ?? match[2]]; | ||
| } | ||
| return value; | ||
| } | ||
|
|
||
| const unmatched = overlay.actions | ||
| .map((a) => a.target) | ||
| .filter((target) => resolve(target) === undefined); | ||
| if (unmatched.length) { | ||
| throw new Error(`openapi/public.yaml targets nothing in the spec:\n ${unmatched.join("\n ")}`); | ||
| } | ||
| console.log(`public.yaml: ${overlay.actions.length} overlay targets match the spec`); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Overlay check has a narrow guarantee
resolveverifies target existence, not whether updates appear in the rendered reference. An overlay-output check is needed to catch application failures.Was this helpful? React with 👍 or 👎 to provide feedback.