Repository navigation
fix(release): drop stderr from the SDK probe receipt - #72
Merged
Merged
Conversation
#71 normalized and sorted the probe's cargo stderr, but Linux dry run 37641703105 still differed between two identical rebuilds in exactly remove-sdk-only-probe.json. The receipt keeps the command, exit code and the packages the probe removed, which is what it is evidence of. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
73
to
75
| 'exit_code': exit_code, | ||
| 'removed_packages': list(removed_packages), | ||
| 'stderr': text, | ||
| } |
There was a problem hiding this comment.
🔍 Unused probe-log normalization remains
sdk_remove_probe still sorts and validates Cargo stderr before discarding it. The canonicalization tests maintain a receipt behavior that no longer exists.
Was this helpful? React with 👍 or 👎 to provide feedback.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux dry run 37641703105 (on #71) still failed the reproducibility compare with
1 differing members:third-party/linux-source-scope/remove-sdk-only-probe.json. #71's sorted, normalized stderr was not stable across two identical rebuilds. The receipt now records the command, exit code and removed packages, as #69 did, and keeps #71'sremoved_packagesfield.Evidence
6d4ab6fe…vsac6577f4…).python3 -m unittest test_linux_source_scope: OK.Merge Danger
Door: two-way.
Blast radius: one receipt in the source archive.
🤖 Generated with Claude Code