Repository navigation
test(desktop): keep update tests independent of the workspace version - #81
Conversation
The update tests served 0.2.0 as the newer build, but the app compares against its own crate version. The 0.2.1 version PR turned 0.2.0 into a downgrade and six tests failed. Newer test builds now use 9.x. Fixes CNV-58
|
| ("0.1.0", "2026-10-01"), | ||
| ("0.2.0", "2026-10-03"), | ||
| ("0.3.0", "2026-10-04"), | ||
| ("9.2.0", "2026-10-03"), |
There was a problem hiding this comment.
Same-version updates lose coverage
Changing the covered build to 9.2.0 removes coverage for a build with the same version as the running app but a later date. On the current workspace version, the old 0.2.0 fixture exercised that case. The existing convt-update tests do not cover it separately, so a change that rejects these builds could pass unnoticed.
Keep these workspace-independent fixtures, but add a dedicated VerifiedManifest::select test with a fixed running version and a same-version, later-date build. This is non-blocking. Confidence: 5/5.
Summary
The 0.2.1 version PR (#76) fails CI because six desktop update tests served
0.2.0as the newer build. The app compares manifest builds against its own crate version, so once Changesets bumped the workspace to 0.2.1,0.2.0became a downgrade andVerifiedManifest::selectfiltered it out. Newer test builds now use9.2.0and9.3.0. Only test code changes.running build = crate VERSION (0.2.0 on main, 0.2.1 on the version PR), dated 2026-10-01 manifest builds: ("0.1.0", "2026-10-01") # older than any real version; unchanged - ("0.2.0", "2026-10-03") # newer only while the app is <= 0.2.0 - ("0.3.0", "2026-10-04") + ("9.2.0", "2026-10-03") # newer than the app at any realistic version + ("9.3.0", "2026-10-04")Evidence
cargo test -p convt-appwith the workspace at 0.2.0. Once this merges, Version Packages regenerates chore(release): version packages #76 and runs the same tests at 0.2.1.Not run locally: the box doesn't have the pinned 1.95 toolchain or the gpui system libraries, so CI is the proof for both versions.
Merge Danger
Door: two-way. Test-only change, so a revert undoes it completely.
Blast radius:
convt-appupdate tests only. The app's update selection and release workflows don't change.Fixes CNV-58
Created with Grok Bot in Grok Bot.