Skip to content

test(desktop): keep update tests independent of the workspace version - #81

Merged
leoisadev1 merged 1 commit into
mainfrom
leoplayz317/cnv-58-version-pr-ci-fails-because-desktop-update-tests-assume-the
Oct 7, 2026
Merged

leoisadev1 merged 1 commit into
mainfrom
leoplayz317/cnv-58-version-pr-ci-fails-because-desktop-update-tests-assume-the

Conversation

@leoisadev1

@leoisadev1 leoisadev1 commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

The 0.2.1 version PR (#76) fails CI because six desktop update tests served 0.2.0 as the newer build. The app compares manifest builds against its own crate version, so once Changesets bumped the workspace to 0.2.1, 0.2.0 became a downgrade and VerifiedManifest::select filtered it out. Newer test builds now use 9.2.0 and 9.3.0. Only test code changes.

 running build = crate VERSION (0.2.0 on main, 0.2.1 on the version PR), dated 2026-10-01
 manifest builds:
   ("0.1.0", "2026-10-01")   # older than any real version; unchanged
-  ("0.2.0", "2026-10-03")   # newer only while the app is <= 0.2.0
-  ("0.3.0", "2026-10-04")
+  ("9.2.0", "2026-10-03")   # newer than the app at any realistic version
+  ("9.3.0", "2026-10-04")

Evidence

  • Before: CI run 37678677744 on chore(release): version packages #76 (workspace at 0.2.1), Rust (Linux, desktop) and Rust (Windows, desktop):
    ---- ui::tests::a_covered_update_shows_and_opens_the_download_page stdout ----
    assertion `left == right` failed
      left: NotCovered { version: "0.3.0", date: "2026-10-04", purchase_url: "https://convt.test/pricing" }
     right: Available { version: "0.2.0", date: "2026-10-03", uncovered: Some("0.3.0") }
    test result: FAILED. 99 passed; 6 failed
    
  • After: CI on this PR runs cargo test -p convt-app with the workspace at 0.2.0. Once this merges, Version Packages regenerates chore(release): version packages #76 and runs the same tests at 0.2.1.

Not run locally: the box doesn't have the pinned 1.95 toolchain or the gpui system libraries, so CI is the proof for both versions.

Merge Danger

Door: two-way. Test-only change, so a revert undoes it completely.

Blast radius: convt-app update tests only. The app's update selection and release workflows don't change.

Fixes CNV-58

Created with Grok Bot in Grok Bot.


Devin Review

The update tests served 0.2.0 as the newer build, but the app compares
against its own crate version. The 0.2.1 version PR turned 0.2.0 into a
downgrade and six tests failed. Newer test builds now use 9.x.

Fixes CNV-58

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Low risk] Test file updates version numbers in update checks.

The PR appears safe to merge, with a non-blocking suggestion to preserve coverage for same-version rebuilds.

Fix All in Claude CodeFindings

  1. P2 Same-version updates lose coverage ▶

Summary

This PR changes desktop update test builds to 9.2.0 and 9.3.0, updates their expected text, and explains why the fixtures use higher versions.

  • The covered-update and renewal expectations remain consistent.
  • One non-blocking test gap remains: same-version builds with later dates lose coverage.
  • Tests were not run during this review.

Reviews (1) · Last reviewed commit: "test(desktop): keep update tests indepen..." · Reviewed by Greptile

("0.1.0", "2026-10-01"),
("0.2.0", "2026-10-03"),
("0.3.0", "2026-10-04"),
("9.2.0", "2026-10-03"),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Same-version updates lose coverage

Changing the covered build to 9.2.0 removes coverage for a build with the same version as the running app but a later date. On the current workspace version, the old 0.2.0 fixture exercised that case. The existing convt-update tests do not cover it separately, so a change that rejects these builds could pass unnoticed.

Keep these workspace-independent fixtures, but add a dedicated VerifiedManifest::select test with a fixed running version and a same-version, later-date build. This is non-blocking. Confidence: 5/5.

Fix in Claude Code

@leoisadev1
leoisadev1 merged commit b05a596 into main Oct 7, 2026
10 checks passed
@leoisadev1
leoisadev1 deleted the leoplayz317/cnv-58-version-pr-ci-fails-because-desktop-update-tests-assume-the branch October 7, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant