Repository navigation
test(app): update fixtures follow the running version - #87
Closed
leoisadev1 wants to merge 2 commits into
Closed
leoisadev1 wants to merge 2 commits into
leoisadev1 wants to merge 2 commits into
Conversation
Version Packages PR #76 bumps the app to 0.2.1, and six update tests failed on every platform: their 'newer' builds were the literal 0.2.0 and 0.3.0, and the app rightly never offers a build older than itself. The fixtures now use the running VERSION with a later date for the covered update and the next minor version for the uncovered one, so a version bump can't break them. Passes at 0.2.0 and 0.2.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on Version Packages PR #76 (0.2.1) failed six convt-app update tests on Linux, macOS and Windows. Their fixtures offered literal builds 0.2.0 and 0.3.0 as updates; at 0.2.1, 0.2.0 is older than the running app, which
selectcorrectly never offers. The fixtures now use the runningVERSIONwith a later build date for the covered update and the next minor version for the uncovered one.Evidence
cargo test -p convt-appwithCargo.tomlat 0.2.1: 105 passed. At 0.2.0 (main): the 6 update tests pass.cargo clippy -p convt-app --tests -- -D warnings: clean.Merge Danger
Door: two-way. Tests only.
Blast radius: convt-app update tests.
🤖 Generated with Claude Code