Skip to content

Fix Windows builds for 5.x branch. #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asmorkalov merged 5 commits into from
Jun 19, 2026
+8 −5
Merged

Fix Windows builds for 5.x branch. #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
215c0ea
Fix Windows builds for 5.x branch.
asmorkalov Jun 18, 2026
d4df7f6
Disable NASM for experiment.
asmorkalov Jun 18, 2026
06719d4
Break mingw cc.exe to exclude it from assember search.
asmorkalov Jun 18, 2026
807f11f
Hardcode NASM assember first in PATH
asmorkalov Jun 18, 2026
5592c0e
Hardcode NASM path as ASM compiler for experiment.
asmorkalov Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build_wheels_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:

jobs:
Build:
runs-on: windows-2025
runs-on: windows-2022
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
python --version
python -m pip install --upgrade pip
python -m pip install --upgrade setuptools
python -m pip install cmake==3.24.2
python -m pip install cmake==4.3.2
python -m pip install toml && python -c "import toml; c = toml.load('pyproject.toml'); print('\n'.join(c['build-system']['requires']))" >> requirements.txt | python -m pip install -r requirements.txt
set "CI_BUILD=1" && python setup.py bdist_wheel --py-limited-api=cp37 --dist-dir=%cd%\wheelhouse -v
shell: cmd
Expand All @@ -77,14 +77,14 @@ jobs:

Test:
needs: [Build]
runs-on: windows-2025
runs-on: windows-2022
defaults:
run:
shell: cmd
strategy:
fail-fast: false
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
platform: [x86, x64]
with_contrib: [0, 1]
without_gui: [0, 1]
Expand Down
5 changes: 4 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,11 @@ def main():
# Raw paths relative to sourcetree root.
files_outside_package_dir = {"cv2": ["LICENSE.txt", "LICENSE-3RD-PARTY.txt"]}

# HACK: Disabled generic assembler for now.
# Windows 2025 CI environment does not provide suitable assembler or build is broken in OpenCV MLAS.
ci_cmake_generator = (
["-G", "Visual Studio 17 2022"]
["-G", "Visual Studio 17 2022",
"-DCMAKE_ASM_COMPILER="]
if os.name == "nt"
else ["-G", "Unix Makefiles"]
)
Expand Down
Loading