Show every file in the picker, and start it at the last document - #696
Merged
Merged
Conversation
Users report that they cannot find their documents in the file picker. Since #547, findDocument gave the picker an EXTRA_MIME_TYPES filter. The picker does not grey out a file that fails the filter. It leaves the file out, so the user thinks that the file is not on the phone. A provider can report a type that the core's table does not spell, and then a document the app can open disappears. The filter is gone, and the picker shows all files again, as it did before #547. The picker also opens in Recent or Downloads, far from the folder that the user keeps documents in. findDocument now gives the newest recent document as EXTRA_INITIAL_URI, and the picker opens in its folder. Only a document uri works, so an entry from ACTION_VIEW is skipped. A line under the Open button tells the user about the picker's drawer and about opening the file from a file manager. Only this new string is translated; the strings that main is already missing stay out of scope. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015SXh6wJbDML5JLK8b1CsYb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users report that they cannot find their documents in the file picker.
What changes
findDocumentgave the picker anEXTRA_MIME_TYPESfilter. The picker does not grey out a file that fails the filter. It leaves the file out, so the user thinks that the file is not on the phone. A provider can report a type that the core's table does not spell, and then a document that the app can open disappears. The filter is gone, and the intent uses only*/*, as it did before Redesign: Material 3, recent documents as the landing screen, and actions at the thumb #547.findDocumentgives the newest recent document asEXTRA_INITIAL_URI. Only a document uri works, so the code skips an entry that came fromACTION_VIEW.mainis already missing in each language are out of scope.Tests
On an API 36 emulator:
Documents/Work/report.odt, the next picker opened inDocuments › Work.spotlessCheck,assembleDebug,lintProDebug,testProDebugUnitTestandLandingTests(16 tests) pass.🤖 Generated with Claude Code