Prepare 4.21.0: the free tool first, translations and store notes - #698
Merged
Merged
Conversation
CI failed on aSheetCellTakesAFill in lite. Its emulator is 320dp wide, so the Pro badge and four toggles pushed the fill partly off screen. A locked strip now puts its free tool right after the badge. The free tool also shows its state now, so a second tap takes it off. The alignment row hides the empty slot under its icons, and a locked tool over a sheet offers Pro in a sheet's words. translate-app.py read and wrote only <string> elements, so it dropped the edit_cells_stale plurals from every language. It now keeps the plurals blocks a translation has. The 23 strings that every language lacked are added, and no existing translation changes. The store notes of 4.21.0 are in all 15 locales. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTmf15E1oFAe5PrtjT2Cz8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI failure of #697. Only
aSheetCellTakesAFillfailed, and only in lite. The CI emulator is 320dp wide. The Pro badge and four toggles pushed the fill tool partly off screen, so Espresso refused the tap. On a 320dp screen, the old order fails with the same error, and the new order passes.The fix is in the app, not in the test:
pro_offer_sheet, that names the fill as the free tool.Translations. Every language lacked 23 strings: the 8 from #697 and 15 older ones, including the three Pro offers. The diff adds 437 lines and removes none.
scripts/translate-app.pyreads and writes only<string>elements, and it rewrites each file from the start. So it deleted theedit_cells_staleplurals from all 19 languages. The script now keeps the plurals blocks that a translation has. Its default review pass also reworded hundreds of existing translations. I did not keep those changes, and I took only the missing keys from its output.Store notes. I wrote the English notes for 4.21.0 by hand, because the generated text left out cell formatting and alignment.
store-copy.pytranslated them. All 15 locales are under 500 characters, and the longest is French, at 461.store-listing.py --version v4.21.0passes.Test plan
spotlessCheck assembleDebug lintProDebug lintLiteDebug testProDebugUnitTestconnectedProDebugAndroidTestandconnectedLiteDebugAndroidTest: 98 of 98 each on Pixel_6_Pro (API 31)MainActivityTestson a 320dp screen (wm density 720): 18 of 18test.odt(four choices)🤖 Generated with Claude Code