Skip to content

Give Pro and Lite their own edit screenshot - #699

Merged
andiwand merged 1 commit into
mainfrom
lite-edit-screenshot
Oct 3, 2026
Merged

andiwand merged 1 commit into
mainfrom
lite-edit-screenshot

Conversation

@andiwand

@andiwand andiwand commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Summary

This is the Android version of OpenDocument.ios#210.

In an edit, Lite dims the Pro tools behind a badge. Both listings got the Pro picture, so the Lite listing showed tools that Lite does not have.

  • ScreenshotTests takes the edit a second time, as 04-edit-lite. The run is a Pro build, so the test locks the strip itself with EditingTools.showFormatting(locked = true). It does this after the page turns editable and before the tap into the page. The selection from the tap then reaches the locked strip, as it does in Lite. The app code does not change, so the rule "no screenshot back door" in CLAUDE.md still holds.
  • store_screenshots.py --stage now requires --app pro|lite. For Lite, it puts 04-edit-lite in the place of 04-edit. The check without --stage requires all seven pictures.
  • frame-screenshots.py gives 04-edit-lite the headline of 04-edit and the same place on the dashed line.
  • The Fastfile stages each flavor's own set.

The release run takes the screenshots again, so this goes out with 4.21.0.

Test plan

  • spotlessCheck, and assembleProDebugAndroidTest compiles
  • ScreenshotTests on API 36 (ODR_Screenshots), phone, en-US and ja-JP: seven pictures each. I framed them and compared both edits by eye: Lite shows the badge, the highlighter first and dimmed Pro tools, and keeps the "12 pt" caption.
  • store_screenshots.py on a fake set for 15 locales: the check passes, --stage without --app fails, --app pro stages the Pro edit, and --app lite stages the Lite edit as 04-edit.png in the phone and both tablet slots.

Note on local runs: the Play Store on the ODR_Screenshots AVD had updated Gboard to 18.0.3. That version always shows a header Button, so sendAwayWhatTheKeyboardIsAsking fails, also on main. I rolled the AVD back to the preloaded 15.1 with cmd package uninstall-system-updates. The CI image runs the preloaded version, so CI is not affected.

🤖 Generated with Claude Code

Lite dims pro's tools behind a badge in an edit, but both listings got
the pro picture, so the lite listing showed tools that lite does not
have. ScreenshotTests now takes the edit a second time as
04-edit-lite. The run is a pro build, so the test locks the strip
itself before it taps into the page. Nothing in the app changes.

store_screenshots.py --stage takes --app, and puts 04-edit-lite in
place of 04-edit for lite. frame-screenshots.py gives it the headline
and the place of 04-edit. The Fastfile stages each flavor's own set.
This is the same change as OpenDocument.ios#210.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VTmf15E1oFAe5PrtjT2Cz8
@andiwand
andiwand merged commit f235942 into main Oct 3, 2026
2 checks passed
@andiwand
andiwand deleted the lite-edit-screenshot branch October 3, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant