Give Pro and Lite their own edit screenshot - #699
Merged
Merged
Conversation
Lite dims pro's tools behind a badge in an edit, but both listings got the pro picture, so the lite listing showed tools that lite does not have. ScreenshotTests now takes the edit a second time as 04-edit-lite. The run is a pro build, so the test locks the strip itself before it taps into the page. Nothing in the app changes. store_screenshots.py --stage takes --app, and puts 04-edit-lite in place of 04-edit for lite. frame-screenshots.py gives it the headline and the place of 04-edit. The Fastfile stages each flavor's own set. This is the same change as OpenDocument.ios#210. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTmf15E1oFAe5PrtjT2Cz8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the Android version of OpenDocument.ios#210.
In an edit, Lite dims the Pro tools behind a badge. Both listings got the Pro picture, so the Lite listing showed tools that Lite does not have.
ScreenshotTeststakes the edit a second time, as04-edit-lite. The run is a Pro build, so the test locks the strip itself withEditingTools.showFormatting(locked = true). It does this after the page turns editable and before the tap into the page. The selection from the tap then reaches the locked strip, as it does in Lite. The app code does not change, so the rule "no screenshot back door" inCLAUDE.mdstill holds.store_screenshots.py --stagenow requires--app pro|lite. For Lite, it puts04-edit-litein the place of04-edit. The check without--stagerequires all seven pictures.frame-screenshots.pygives04-edit-litethe headline of04-editand the same place on the dashed line.Fastfilestages each flavor's own set.The release run takes the screenshots again, so this goes out with 4.21.0.
Test plan
spotlessCheck, andassembleProDebugAndroidTestcompilesScreenshotTestson API 36 (ODR_Screenshots), phone,en-USandja-JP: seven pictures each. I framed them and compared both edits by eye: Lite shows the badge, the highlighter first and dimmed Pro tools, and keeps the "12 pt" caption.store_screenshots.pyon a fake set for 15 locales: the check passes,--stagewithout--appfails,--app prostages the Pro edit, and--app litestages the Lite edit as04-edit.pngin the phone and both tablet slots.Note on local runs: the Play Store on the
ODR_ScreenshotsAVD had updated Gboard to 18.0.3. That version always shows a headerButton, sosendAwayWhatTheKeyboardIsAskingfails, also onmain. I rolled the AVD back to the preloaded 15.1 withcmd package uninstall-system-updates. The CI image runs the preloaded version, so CI is not affected.🤖 Generated with Claude Code