Ask for a review when a document from another app is put down - #701
Merged
Merged
Conversation
The ask came only at the list or at app start, and a user who opens files from other apps reaches neither. Back on such a document now asks if the review is earned, and leaves the app when the sheet closes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AK12MgSt5U9MA7dQaCQyqU
Back no longer waits on the network: the sheet is fetched once an externally opened document has rendered, and back shows it only if it has arrived. Otherwise back leaves at once. leaveApp also returns when the activity is already destroyed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AK12MgSt5U9MA7dQaCQyqU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #624 the review ask comes only when a document is closed back to the list, or when the app starts on the landing screen. A user who opens files from a file manager, mail or a messenger reaches neither: back leaves the app. Free-edition ratings fell from ~15 a day in August to ~1.3 a day since 4.19.1 reached most users.
When an externally opened document has rendered and
ReviewInvitationsays the ask is earned, the review sheet is fetched in the background. Back on that document shows the sheet if it has arrived and leaves the app when it closes; otherwise back leaves at once, as before. A failed document never asks. The foss build has no sheet and always leaves at once.Not tried on a device. Check that the sheet shows over the document and the app closes after it.
🤖 Generated with Claude Code