fix: change SupportContactEnterpriseTagStep to accept/return full context - #2691
Merged
brobro10000 merged 1 commit intoSep 10, 2026
Merged
Conversation
…text Per pwnage101's review feedback on edx-platform PR openedx#455, matches the updated SupportContactContextRequested filter shape: run_filter now takes a single context dict (reading/writing context['tags']) instead of a bare tags list plus an unused user argument. user was never actually used by this step in the first place — get_current_request() already provides everything needed via crum. ENT-11574
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2691 +/- ##
=======================================
Coverage 87.03% 87.03%
=======================================
Files 264 264
Lines 17247 17248 +1
Branches 1705 1705
=======================================
+ Hits 15011 15012 +1
Misses 1897 1897
Partials 339 339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pwnage101
approved these changes
Sep 10, 2026
This was referenced Sep 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to openedx-filters PR #394, addressing review feedback on the sibling edx-platform PR #455.
SupportContactEnterpriseTagStep.run_filternow takes a singlecontext: dict(reading/writingcontext['tags']) instead of a baretagslist plus an unuseduserargument.userwas never actually used by this step —get_current_request()already provides everything needed viacrum.Since the original shape (#2688) already merged and released as 8.10.0, this is a new PR rather than an amendment.
Companion PRs
ENT-11574