feat!: remove pact provider verification; drop Django 4.2; bump codecov - #615
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 94.78% 97.63% +2.84%
==========================================
Files 33 28 -5
Lines 3358 3259 -99
Branches 129 124 -5
==========================================
- Hits 3183 3182 -1
+ Misses 157 60 -97
+ Partials 18 17 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
feanil
force-pushed
the
fix/pact-verification-fork-prs
branch
from
June 18, 2026 14:38
da7785c to
7fdb666
Compare
feanil
changed the title
feanil
marked this pull request as ready for review
June 18, 2026 15:13
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
v5.5.4 fails GPG signature verification of the codecov CLI because the codecovsecurity keybase account was deprecated. v7.0.0 (and the v5.5.5 patch) migrate to the keybase.io/codecovsecops account. See codecov/codecov-action#1956 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Django 4.2 is being dropped everywhere. Remove the django42 tox env, the Django 4.2 PyPI classifier, the django42 matrix entry in CI, and update the pact verification job to install Django 5.2 instead of 4.2. The 'Run Coverage' step's matrix gate is moved from django42 to django52 so coverage upload continues to fire once per CI run. BREAKING CHANGE: Django 4.2 is no longer supported. Consumers must upgrade to Django 5.2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The consumer-side pact source (edx/video-encode-manager) is now a private third-party repo, so the documented "manually copy from upstream" process for keeping the in-tree pact JSON in sync is no longer workable. The local JSON has not been updated since 2021-11-04 and verifying against it produces stale/false signals. Remove the pact tooling entirely: * delete edxval/pacts/ (verifier, middleware, provider state views, the stale JSON, README) * delete edxval/settings/pact.py * delete the provider-verification job in ci.yml and the verify_changed_contract.yml workflow * drop the pact-provider URL registration from edxval/urls.py * drop pact-python from requirements/test.in and its pin from requirements/constraints.txt BREAKING CHANGE: pact provider verification is no longer part of this repo. Any external systems triggering the 'contract_changed' repository_dispatch event will no-op. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Regenerate the pinned requirements files now that pact-python and its constraint are gone. Picks up incidental upgrades from running make upgrade. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Two breaking changes since 4.0.1: drop Django 4.2 support, remove pact provider verification. Bump per semver. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
feanil
force-pushed
the
fix/pact-verification-fork-prs
branch
from
June 23, 2026 15:15
7fdb666 to
ff0c83e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates several related cleanups originally motivated by trying to get the pact provider verification job working for fork PRs. Investigation revealed the local pact JSON (the only mode fork PRs could use, since they cannot access the
PACT_FLOW_ACCESS_TOKENsecret) has not been updated since 2021-11-04, and the consumer-side source (edx/video-encode-manager) is now a private third-party repo with no workable sync path. Rather than maintain a slowly-rotting snapshot, the pact tooling is removed entirely.While here, bump codecov-action to v7.0.0 — the v5.5.4 we were pinned to fails GPG verification since the codecovsecurity keybase account was deprecated. See codecov/codecov-action#1956.
Breaking changes
contract_changedrepository_dispatchevent will no-op.