Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 3e0db9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
# Conflicts: # packages/tests-unit/tests/build/copyTracedFiles.test.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copyTracedFilesnow rejects destinations outsideoutputDirbefore the traced-file copy loop.Dependencies outside the app can produce these destinations, which let the copy loop and later code patches modify source dependencies.
In
packages/open-next/src/build/copyTracedFiles.ts, the check covers every queued destination and throws an error with the source and destination paths.The check runs outside route error handlers, so optional routes cannot suppress the rejection.
Valid destinations inside
outputDir/node_moduleskeep their existing layout.Nine regression cases for server traces, instrumentation, middleware, ordinary routes, and optional error routes fail without the change and pass with it.
The full Cloudflare reproduction was not run.
Fixes #1260.