Repository navigation
fix(cli): honor --dangerously-use-unsupported-next-version when passed as standalone flag - #1319
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 514b527 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…d as standalone flag
muhammadrizkirijalags
force-pushed
the
fix-command-parsing
branch
from
October 21, 2026 10:27
d4cf6e7 to
2fed0cf
Compare
…an flag and add tests
commit: |
vicb
approved these changes
Oct 21, 2026
vicb
left a comment
vicb
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix @muhammadrizkirijalags! I pushed a follow-up commit on top of yours:
- Moved the CLI arg parsing into
utils/args.tsso it can be unit tested.parseArgs()now returns named fields instead of a loose key/value map. --helpand--dangerously-use-unsupported-next-versionare now proper boolean flags. They'retruewhen present and never take the next argument as a value. Value flags (--config-path,--node-externals) work as before.- Added unit tests in
tests/utils/args.test.ts. - Added the flag to the CLI help text and fixed the missing newline at the end of the changeset.
Contributor
|
The e2e test fails because #1321 is not merged yet, so there is an (expected) error with Next 15 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1318
This pull request makes a small change to how the presence of the
--dangerously-use-unsupported-next-versionargument is detected inpackages/open-next/src/index.ts. Instead of checking if the argument is notundefined, it now explicitly checks if the argument key exists in the parsed arguments object. This improves reliability when handling CLI flags.