Repository navigation
Conversation
627150795
force-pushed
the
fix/session-worktree-umask-908
branch
from
October 29, 2026 01:57
8ee01a4 to
831318d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #908. Session worktree snapshots apply a tracked-file Git patch after creating a detached checkout. Under
umask 077, Git can apply the executable mode as0700, dropping group and other execute bits from tracked scripts.Value
Session worktrees preserve executable tracked files under restrictive POSIX umasks, so scripts remain runnable by the intended users.
Approach
100755paths from the snapshot's temporary Git index.umask 022andumask 077; restore the process umask infinally.Validation
Validated against rebased PR head
831318dd280d1d9d4a1611541855d17620046c35.node --test --experimental-strip-types tests/web/session-worktree.test.ts— 27/27 passed on Linux/WSL with Node 22.19.0.bun run check— passed with Node 22.19.0 and Bun 1.3.14.VITEST_MAX_WORKERS=1 bun run test— passed: Node 2,428 passed / 8 platform skips; Vitest 1,623 passed across 107 files. The worker cap accounts for WSL reporting 24 parallel CPUs despite lower effective throughput; no project test configuration was changed.40803485954— not green: 13 checks passed, 3 failure entries (one root Web E2E shard and two aggregate checks), and 2 downstream checks were cancelled. The root failure timed out in the unrelatedtests/web/openpi-web.e2e.tsunknown-prompt-admission case after the “send as new message” button stayed disabled for 30 seconds. GitHub rerun requires repository admin rights; the local retry could not start because Chromium is absent from the WSL Playwright cache.git diff --check— passed.100644 → 100755produces0700underumask 077and0755underumask 022before the fix.Impact
100755receive execute-bit restoration.