Repository navigation
Render castellated pad holes with board clipping and continuous outlines #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
qu1ck
merged 5 commits into
openscopeproject:master
from
tytelmaier:fix/325-castellated-holes
Oct 14, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8dccb3a
Render castellated pad holes using board clipping
tytelmaier 68adfce
Draw continuous outlines around castellated holes
tytelmaier 062d533
Refine board clipping and cover KiCad compatibility
tytelmaier 77d0475
Keep existing CI setup with expanded KiCad matrix
tytelmaier bb343cb
Support SVG board clipping and refine outline widths
tytelmaier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,6 +67,9 @@ | |
| "edges": { | ||
| "$ref": "#/definitions/DrawingArray" | ||
| }, | ||
| "board_clip": { | ||
| "$ref": "#/definitions/ClippingRegion" | ||
| }, | ||
| "drawings": { | ||
| "$ref": "#/definitions/LayerDrawings" | ||
| }, | ||
|
|
@@ -599,6 +602,19 @@ | |
| ], | ||
| "title": "Zone" | ||
| }, | ||
| "ClippingRegion": { | ||
| "description": "Board-coordinate contours, filled with the even-odd rule.", | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "svgpath": { "type": "string" }, | ||
| "polygons": { "$ref": "#/definitions/Polygons" } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add option to pass geometry as svgpath. For some CAD packages they might support native arcs in the outline and this is preferable format. Make any of [svgpath, polygons] required similar to other structs containing svgpath. |
||
| }, | ||
| "anyOf": [ | ||
| { "required": [ "svgpath" ] }, | ||
| { "required": [ "polygons" ] } | ||
| ] | ||
| }, | ||
| "Polygons": { | ||
| "type": "array", | ||
| "items": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.