-
Notifications
You must be signed in to change notification settings - Fork 11
fix(operational-dashboard): remove stray unused widget catalog entries #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,7 +68,6 @@ import { | |
| InventorySummaryCard, | ||
| ManagedClusterProvidersCard, | ||
| ManagedClusterRegionsCard, | ||
| ManagedClusterStatusCard, | ||
| ManagedDatabaseStatusCard, | ||
| MetricCard, | ||
| NodeStatusCard, | ||
|
|
@@ -82,7 +81,7 @@ import { useGetMetricsData } from "./get-metrics-data"; | |
|
|
||
| const baseTemplate = defaultDashboardLayoutTemplate; | ||
|
|
||
| const LAYOUT_STORAGE_KEY = "hypershell.operational-dashboard.layout.v28"; | ||
| const LAYOUT_STORAGE_KEY = "hypershell.operational-dashboard.layout.v29"; | ||
| const CUSTOM_COLUMNS: Record<Variants, number> = { | ||
| xl: 4, | ||
| lg: 4, | ||
|
|
@@ -225,10 +224,6 @@ function createWidgetMapping( | |
| } | ||
|
|
||
| if (metricType === "inventory-status") { | ||
| if (metricId === "managed-clusters") { | ||
| return <ManagedClusterStatusCard metric={metric} />; | ||
| } | ||
|
|
||
| return <ManagedDatabaseStatusCard metric={metric} />; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Spec consistency: this simplification (and the catalog deletions in this hunk and below) removes the |
||
| } | ||
|
|
||
|
|
@@ -461,53 +456,6 @@ function createWidgetMapping( | |
| "inventory-regions", | ||
| ), | ||
| }, | ||
| "managed-clusters": { | ||
| defaults: METRIC_WIDGET_DEFAULTS, | ||
| config: { | ||
| icon: <ClusterIcon />, | ||
| title: intl.formatMessage(messages.widgetManagedClusters), | ||
| }, | ||
| renderWidget: () => | ||
| renderMetric( | ||
| "managed-clusters", | ||
| "", | ||
| messages.widgetManagedClusters, | ||
| "metric", | ||
| ), | ||
| }, | ||
| "managed-cluster-status": { | ||
| defaults: { | ||
| h: NODE_STATUS_WIDGET_HEIGHT, | ||
| maxH: NODE_STATUS_WIDGET_HEIGHT + 2, | ||
| minH: METRIC_WIDGET_DEFAULTS.minH, | ||
| w: 1, | ||
| }, | ||
| config: { | ||
| icon: <ClusterIcon />, | ||
| title: intl.formatMessage(messages.widgetManagedClusterStatus), | ||
| }, | ||
| renderWidget: () => | ||
| renderMetric( | ||
| "managed-clusters", | ||
| "", | ||
| messages.widgetManagedClusterStatus, | ||
| "inventory-status", | ||
| ), | ||
| }, | ||
| "managed-databases": { | ||
| defaults: METRIC_WIDGET_DEFAULTS, | ||
| config: { | ||
| icon: <DatabaseIcon />, | ||
| title: intl.formatMessage(messages.widgetManagedDatabases), | ||
| }, | ||
| renderWidget: () => | ||
| renderMetric( | ||
| "managed-databases", | ||
| "", | ||
| messages.widgetManagedDatabases, | ||
| "metric", | ||
| ), | ||
| }, | ||
| "managed-database-status": { | ||
| defaults: { | ||
| h: NODE_STATUS_WIDGET_HEIGHT, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.