Repository navigation
feat(data-model): deprecate GatewayRelease and GatewayNetwork, add kind-removal wave pattern - #453
Closed
markturansky wants to merge 1 commit into
Closed
markturansky wants to merge 1 commit into
markturansky wants to merge 1 commit into
Conversation
Mark both kinds as Slated for Removal in the data model spec: - GatewayRelease: Gateway image/supervisor_image fields make the release indirection layer unnecessary; canary rollout was never adopted. - GatewayNetwork: The reconciler owns no K8s resources and only validates topology fields; real mesh/tunnel provisioning was never defined. Remove both from the ER diagram. Add deprecation banners to their requirement sections. Mark API routes, CLI sections, and hsctl apply rows as [REMOVED]. Add design decision rationale for both removals. Add 20 RM- gap items to skills/RECONCILE.md covering all 8 implementation layers (FE -> CLI -> CP -> BE+gRPC -> API+SDK -> DB) in reverse-dependency removal order. Extend skills/build/reconcile/SKILL.md with a Kind Removal Wave Pattern and skills/build/full-stack-pipeline/SKILL.md with a reverse-dependency execution note, so /reconcile can plan and execute kind deletion the same way it plans additions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Collaborator
Author
|
Consolidated into PR #452 (feat/adlc-agent-runtime-spec) - one big spec change PR. |
Amber reviewStatus: Stopped The pull request closed before Amber posted the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GatewayReleaseandGatewayNetworkas Slated for Removal inspecs/platform/data-model.spec.md- removed from the ER diagram, deprecation banners added to their requirement sections, API routes and CLI sections marked [REMOVED], design decision rationale added.RM-gap items toskills/RECONCILE.mdcovering all 8 implementation layers (FE -> CLI -> CP -> BE+gRPC -> API+SDK -> DB migration) in reverse-dependency order./reconcileskill with a Kind Removal Wave Pattern and/full-stack-pipelinewith a reverse-dependency execution note, so the same skill machinery that builds new kinds can plan and execute kind deletion.Why these two kinds
GatewayRelease: Gateways already carry
image/supervisor_imagedirectly; the release indirection layer (canary rollout, rollback) added complexity without product adoption.GatewayNetwork: The reconciler explicitly says "applying real gateway-to-gateway connectivity is future work." It owns no Kubernetes resources and only validates topology vocabulary. Being removed until the product defines concrete connectivity semantics.
What this does NOT do
This PR is spec + skill changes only. No code is deleted yet. Running
/reconcileon this branch will plan the 6-wave RM removal and present it for approval before touching any implementation.Test plan
make checkpasses (no em-dashes, pre-commit hooks clean)specs/platform/data-model.spec.mdrenders cleanly (mermaid ER diagram has no GatewayRelease or GatewayNetwork entities)skills/RECONCILE.mdgap table has 20 RM- items, all Missing/reconcile --dry-runon this branch surfaces the RM wave plan🤖 Generated with Claude Code