Skip to content

docs(skills): autonomous dev skills - #460

Open
jsell-rh wants to merge 5 commits into
mainfrom
jsell/spec/autonomous-specs
Open

jsell-rh wants to merge 5 commits into
mainfrom
jsell/spec/autonomous-specs

Conversation

@jsell-rh

@jsell-rh jsell-rh commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Complements #452

@jsell-rh jsell-rh self-assigned this Oct 7, 2026
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Central YAML (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 0e45bb9c-585c-4135-906a-63662b2a01a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@hypershell-delivery

hypershell-delivery Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Amber review: comment

Amber review

Status: Complete

View the submitted review.

hypershell-delivery[bot]

This comment was marked as outdated.

@hypershell-delivery hypershell-delivery Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

This revision keeps the autonomous triage/spec workflow and adds a spec-review skill plus a coherence note in plan/spec; it carries no security or production-code risk. The previously flagged workflow defect and doc issues are still unaddressed, and the new spec-review skill repeats the same broken-link and whitespace patterns, so a cleanup pass is still needed before merge.

Findings

  • [Major] skills/build/triage/SKILL.md L58 - the agent/duplicate action still reads "close the label", but a label cannot be closed. The classification definition (L45) states the duplicate issue "will be closed", so the action must close the issue after labeling. As written, duplicates get labeled but never closed, so the stated triage outcome is never achieved. Tracked in the existing thread: #460 (comment)
  • [Minor] skills/build/spec-review/SKILL.md L34 - new file, same broken relative link as spec-implementation: [spec skill](skills/plan/spec/SKILL.md) does not resolve from skills/build/spec-review/. Use ../../plan/spec/SKILL.md (repo convention, e.g. skills/deploy/ibm-cluster/SKILL.md -> ../deploy-cluster/SKILL.md). See inline comment.
  • [Minor] skills/build/spec-implementation/SKILL.md L33 - the same broken relative link is still present. Prior thread: #460 (comment)
  • [Minor] skills/build/spec-implementation/SKILL.md L49 - still references "SIMPLIFIED TECHNICAL ENGLISH STANDARD" with no definition or link anywhere in the repo, so the instruction is not actionable. spec-review L51 also refers to "simplified technical english" (lowercase) for the same undefined standard; please link or inline the authoritative definition once and reference it consistently. Prior thread: #460 (comment)
  • [Minor] Trailing whitespace remains and was added again: spec-implementation/SKILL.md L26 and L33, triage/SKILL.md L36, and the new spec-review/SKILL.md L9, L34, L41. Run the formatter/pre-commit hook before merge.
  • [Minor] None of the three new skills (triage, spec-implementation, spec-review) are registered in the skills/ list in CLAUDE.md (L24), unlike the other first-class skills. Add them for discoverability. Separately, the spec-implementation name reads as "implement a spec", but the workflow actually creates/updates specs from an issue and lives under skills/build/ rather than skills/plan/; consider a clearer name/location. Non-blocking.
  • [Minor] Workflow handoff is implicit across the three skills: triage emits agent/workable, spec-implementation emits agent/reviewable-spec, and spec-review consumes a PR without gating on any upstream label. If these are meant to form a pipeline, state the expected precondition label each stage reads so the chain is deterministic. Non-blocking.

Cross-PR coordination

No material cross-PR coordination issue requires maintainer action.

Previous concerns

  • [Major] triage L58 "close the label" - still present. Current skills/build/triage/SKILL.md L58 still reads Action: Label the issue as \agent/duplicate`. Then, close the label.` Existing thread: #460 (comment)
  • [Minor] spec-implementation L33 broken relative link - still present. L33 still links skills/plan/spec/SKILL.md instead of ../../plan/spec/SKILL.md. Existing thread: #460 (comment)
  • [Minor] spec-implementation L49 undefined "Simplified Technical English" standard - still present. L49 still says PR Body must conform to SIMPLIFIED TECHNICAL ENGLISH STANDARD. with no definition/link. Existing thread: #460 (comment)
  • [Minor] Trailing whitespace - still present. Confirmed at spec-implementation/SKILL.md L26/L33 and triage/SKILL.md L36 (plus new occurrences in spec-review/SKILL.md).
  • [Minor] New skills not registered in CLAUDE.md; spec-implementation naming/location - still present. CLAUDE.md L24 lists no triage/spec-implementation/spec-review entry.

Findings Summary (ordered by severity, highest first)

  1. [Major] agent/duplicate action says "close the label" instead of closing the issue - duplicates never close - Workflow Correctness (triage L58)
  2. [Minor] Broken relative link to the spec skill in the new spec-review skill - Doc Consistency (spec-review L34)
  3. [Minor] Broken relative link to the spec skill still present - Doc Consistency (spec-implementation L33)
  4. [Minor] References an undefined "Simplified Technical English" standard (two skills) - Spec Completeness (spec-implementation L49, spec-review L51)
  5. [Minor] Trailing whitespace may fail lint/pre-commit - Style (spec-implementation L26/L33; triage L36; spec-review L9/L34/L41)
  6. [Minor] New skills not registered in CLAUDE.md; spec-implementation naming/location mismatch - Consistency (CLAUDE.md L24)
  7. [Minor] Implicit pipeline handoff labels across the three skills - Workflow Clarity

Convention Checklist

Convention Result
No em dashes (use hyphens) Pass
Conventional commit message Pass
Internal links resolve Fail
References point to defined standards Fail
New skills registered in CLAUDE.md Fail
No trailing whitespace (lint/pre-commit) Fail


### Step 2: Review the Specification Changes

Read the [spec skill](skills/plan/spec/SKILL.md).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor] Broken relative link. [spec skill](skills/plan/spec/SKILL.md) does not resolve from skills/build/spec-review/ - it would point at skills/build/spec-review/skills/plan/spec/SKILL.md. Use the repo convention of a relative path: ../../plan/spec/SKILL.md. (This is the same defect already noted on spec-implementation/SKILL.md; also note the trailing whitespace on this line.)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant