feat(adlc): move ADLC extension kinds to /api/hypershell/ext/ URL prefix

[markturansky]

Summary

• Bumps rh-trex-ai to the commit that introduces RegisterPrefixedRoutes (rh-trex-ai#62)
• Migrates all six ADLC extension kinds off the shared /v1 surface onto a distinct /ext prefix:
  • /api/hypershell/ext/agent_runtimes
  • /api/hypershell/ext/inference_routes
  • /api/hypershell/ext/provider_bindings
  • /api/hypershell/ext/provider_specs
  • /api/hypershell/ext/sandbox_templates
  • /api/hypershell/ext/secret_sources
• Core gateway-management kinds (/v1/gateways, /v1/managed_clusters, etc.) are unchanged
• The /ext subrouter carries the identical middleware stack as /v1 (metrics, auth/authz, DB transaction, compression)

Why /ext

These ADLC kinds are intentionally versioned and governed separately from the core gateway-management surface. A distinct URL prefix makes that boundary explicit without requiring a separate server process. The prefix is chosen by the downstream project - the framework does not hardcode it.

Test plan

• go build ./... passes
• go vet ./... passes
• CI green

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 5f26bb47-9f4f-4509-b3a4-d4f342560cde

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[hypershell-delivery]

Amber review

Status: Complete

View the submitted review.

[github-actions]

HyperShell environment destroyed

This ephemeral OpenShift environment has been destroyed. Comment /pr-extend to redeploy it.

[hypershell-delivery]

Verdict

This PR moves the six ADLC extension kinds to a distinct /api/hypershell/ext/ prefix, and the /ext surface is now internally consistent end to end: the source spec, the embedded server OpenAPI, the generated Go client, and both shipped SDKs all agree, and secret_sources is a flat top-level kind. All previously raised Critical and Major concerns are verified fixed against the current code; one pre-existing authz design question (outside this diff) and two cross-PR coordination items are noted below.

Findings

Minor

ADLC kinds fall through to the gateway:creator default authz (pre-existing, not modified here). isAuthorized has no case for agent_runtimes, secret_sources, provider_specs, provider_bindings, inference_routes, or sandbox_templates, so all six resolve to the terminal return hasGatewayCreator(bindings) (components/api-server/pkg/rbac/authorization.go:421), granting any gateway creator full CRUD across the whole /ext surface with no per-resource scoping. This PR does not touch authorization.go, so the behavior is unchanged, but the /ext move keeps the same middleware governing the new surface. Please confirm the coarse model is intended for the ADLC kinds, or file a follow-up to scope them. Confidence: Medium.

Cross-PR coordination

• An open PR (#445) adds Go/TS SDK columns to the specs/platform/data-model.spec.md client-reference tables and documents GatewayNetworks().* and GatewayReleases().* (and their TypeScript equivalents) as implemented SDK bindings. This PR deletes both kinds outright, including their SDK clients and types (components/sdk-go/client/gateway_network_api.go, components/sdk-go/client/gateway_release_api.go, components/sdk-go/types/gateway_network.go, components/sdk-go/types/gateway_release.go), and reworks the same spec file. The two edits are incompatible: #445 would advertise SDK methods this PR removes, and both rewrite the same Gateway Networks / Gateway Releases rows. Maintainers must choose a merge order and ensure the surviving spec does not document removed SDK methods.

• An open PR (#466) adds hsctl commands for the six ADLC kinds and hardcodes their URLs under ExtAPIPrefix = "/api/hypershell/ext" in components/cli/pkg/urls/urls.go. That CLI depends on the /ext surface this PR introduces: if #466 merges before this PR, the CLI will call /api/hypershell/ext/* while the server still serves the ADLC kinds under /v1, producing 404s. Maintainers must land this PR first (or merge the two together) so the CLI prefix matches the served routes.

Previous concerns

• Critical - secret_sources route nested but spec/SDK flat: addressed. The route is now flat (components/api-server/plugins/secretSources/plugin.go:46 -> extRouter.PathPrefix("/secret_sources")), matching the source spec (components/api-server/openapi/openapi.yaml:77), the embedded spec (components/api-server/pkg/api/openapi/api/openapi.yaml:2397), the generated client (components/api-server/pkg/api/openapi/api_default.go:1362), and the Go SDK (components/sdk-go/client/secret_source_api.go:31,47) - all /api/hypershell/ext/secret_sources.
• Major - nested secret_sources ignored {agent_runtime_id} (IDOR): addressed by flattening. The route no longer carries an {agent_runtime_id} segment; secret_sources is a top-level kind resolved by id, consistent with the other five ADLC kinds. No cross-parent segment remains.
• Major - data-model spec documented /v1/agent_runtimes: addressed. specs/platform/data-model.spec.md:431 now reads /api/hypershell/ext/agent_runtimes, and the new "ADLC extension kinds - /api/hypershell/ext/" section (:727) lists flat rows for all six kinds.
• Critical - /v1 vs /ext contract/client mismatch: addressed. The generated client emits /ext (api_default.go:70), matching the routes.
• Critical - embedded pkg/api/openapi not regenerated for /ext: addressed. The embedded contract now routes all six ADLC kinds to /api/hypershell/ext/* (components/api-server/pkg/api/openapi/api/openapi.yaml:1322,1547,1772,1997,2222,2397), and no /api/hypershell/v1/<adlc-kind> reference remains anywhere in components/, specs/, or scripts/.
• Minor - ADLC kinds fall through to gateway:creator authz: still present (components/api-server/pkg/rbac/authorization.go:421), pre-existing and outside this diff (see Findings).

---

Findings Summary (ordered by severity, highest first):

1. [Minor] ADLC kinds fall through to the gateway:creator default authz; confirm intended (pre-existing, outside this diff) - Authz design (authorization.go L421)

Convention Checklist:

Convention	Result
No panic() in production code	Pass
Errors wrapped with context	Pass
No secrets in logs or responses	Pass
Embedded/generated OpenAPI regenerated (not left stale)	Pass
OpenAPI client matches served routes	Pass
Spec consistent with implementation	Pass
Input scoped/validated (nested collection parent)	Pass
Conventional commits	Pass