feat(cli): generate hsctl and its terminal UI with the rh-trex-ai generators

[rh-amarin]

Summary

Generate the hsctl commands and the hsctl tui terminal UI from the OpenAPI description with the rh-trex-ai generators (pinned to the merged PR 58, ff48c56), replacing the hand-written code they supersede.

Changes

• Generation: scripts/generate-cli.sh and generate-tui.sh run the pinned generators from a cached checkout. make check, the hooks and CI fail on stale generated output and on orphaned commands. The vendored cli-generator is removed.
• CLI: list/get/create/update/delete per resource, OIDC login (browser and device flow), logout with revocation, whoami and token refresh are generated. Existing saved logins keep working (same config location and keys).
• Hand-written, by design: apply, service-account and gateway connection commands, the six ext/ extension kinds (the generator supports a single API prefix), the tui wrapper, main.go, go.mod.
• TUI: built on rh-trex-ai tuicmd, reusing the saved login; the bespoke hsctl ui is removed.
• Dependency age policy: also covers the pinned generators' module graphs; age exception for ff48c56 (remove after 2026-10-21).
• make build-cli now runs generate-cli first.
• components/api-server stays on e2ff9d8: the merged trex commit lacks RegisterPrefixedRoutes, which the extension plugins use.

Test plan

• make generate-cli: no drift after rebase on main
• make check passes
• go vet / go test ./... in components/cli
• make unit-test-all: all pass except scripts/skillspector-scan_test.sh (macOS bash 3.2 printf --; also fails on clean main)
• CI

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: ab069c17-81a4-48cb-a8fb-096f299cdaa0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[hypershell-delivery]

Amber review

Status: Complete

View the submitted review.

[hypershell-delivery]

Verdict

The head commit resolves both prior actionable findings: the Makefile no longer defaults the generator source to a personal fork, and the hand-written tui wrapper now guards against a nil config before calling cfg.Armed(). The only remaining items are an informational, upstream-owned convention gap in generator output and a cross-PR coordination decision on the CLI's generated-vs-hand-written boundary.

Summary

This PR replaces the hand-written hsctl CLI and TUI with output from the SHA-pinned rh-trex-ai generators, keeping a small hand-maintained surface (main.go, the tui wrapper, apply, revoke, scoped service-account and ext/ extension commands, and the generation scripts). The generator-driven model is well guarded: generate-cli.sh/generate-tui.sh run from a checkout that refuses dirty or SHA-mismatched trees, make check fails on drift and on orphaned resource commands, and the dependency-age exception is time-bounded and justified. Hand-written code avoids panic(), propagates errors, validates the issuer, and keeps secrets out of logs.

Findings

[Minor, informational] Generated resource commands wrap errors with %v, not %w. For example components/cli/cmd/hsctl/delete/gateway/cmd.go:61 uses fmt.Errorf("can't delete gateway: %v", err), which drops the error chain and deviates from the repo convention. These files are generator output (replaced by make generate-cli and drift-checked), so the fix belongs in the rh-trex-ai templates rather than in this repo; raising an upstream issue would let the convention hold once the pin advances. Confidence: High.

Previous concerns

• [Major] Generator source defaults to a personal fork - Addressed. The head commit removes the TREX_REPO?=https://github.com/rh-amarin/rh-trex-ai override and its export from the Makefile (see git show 0c175e5), and the checkout now defaults to upstream at scripts/lib/trex-checkout.sh:19 (TREX_REPO="${TREX_REPO:-https://github.com/openshift-online/rh-trex-ai}"). make build-cli/make check/hooks no longer depend on an individual's fork.
• [Minor] Hand-written tui wrapper dereferences a possibly-nil config - Addressed. components/cli/cmd/hsctl/tui/cmd.go:29-31 now returns an error when config.Load() yields (nil, nil) before calling cfg.Armed(), mirroring the login guard and keeping the newly exported config.SetStore extension point safe.
• [Minor, informational] Generated resource commands wrap errors with %v - Still present at components/cli/cmd/hsctl/delete/gateway/cmd.go:61, but this is generator/upstream output (see the finding above); not a HyperShell-owned fix.

Cross-PR coordination

A gateway-access management pull request adds a new gatewayAccess resource to the CLI by hand-editing the parent command files that this PR converts to generator output, which forces a maintainer decision on merge order and on the generated-vs-hand-written boundary.

• PR #447: It adds gatewayAccess CLI commands and, to register them, hand-edits components/cli/cmd/hsctl/{create,delete,list}/cmd.go, rewrites main.go, and introduces a new hand-written cmd/hsctl/update/cmd.go parent that registers only gatewayAccess. This PR instead makes those parent files generator output: create/delete/list/cmd.go and update/cmd.go are copied from the generator and drift-checked by make check (scripts/generate-cli.sh), and update/cmd.go is the generated parent registering gateway and managedCluster. After this PR merges, #447's hand edits to the generated parents are overwritten and would fail check-cli-drift, and its new update/cmd.go collides structurally with the generated one. #447 also gives gatewayAccess custom verbs (grant/change-role/revoke) that the resource generator does not emit. Maintainers need to decide whether gatewayAccess is a generated core command or a hand-written one (and, if hand-written, register it via the extgroup/HAND_MAINTAINED_COMMANDS mechanism this PR establishes), and to sequence the two PRs so the later one rebases onto the chosen CLI model.

Findings Summary (ordered by severity, highest first)

1. [Minor] Generated resource commands wrap errors with %v instead of %w - Convention (generated/upstream) (delete/gateway/cmd.go L61)

Convention Checklist

Convention	Result
No panic() in production code	Pass
Errors wrapped with fmt.Errorf("...: %w", err)	Fail (generated commands use %v)
No secrets in logs or error messages	Pass
Input validated (issuer URL, token file)	Pass
Proper context propagation (no context.TODO())	Pass
OpenAPI/generated client not manually edited	Pass (drift-checked by make check)
Conventional commit messages	Pass
Dependency age / pins policy honored	Pass (time-bounded, justified exception)