Enable prefix caching for RHAIIS CPT pipelines - #275
Harshith-umesh merged 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe orchestration configuration sets cache options for vLLM release, competitive, and regression pipelines, and for SGLang and TensorRT-LLM competitive pipelines. ChangesPipeline cache settings
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Feature Merge Risk: ⚪ Minimal · up to No confirmed caching regression blocks merging. The effective TensorRT-LLM setting remains unverified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Enable prefix caching for every RHAIIS CPT pipeline, using the setting for its runtime:
rhaiis.engines.vllm.args.enable-prefix-caching: truerhaiis.engines.sglang.args.disable-radix-cache: falserhaiis.engines.trtllm.trtllm_config.kv_cache_config.enable_block_reuse: trueThis ensures CPT submissions explicitly enable prefix caching, including where the Forge engine defaults disable it.
Validation
git diff --checkSummary by CodeRabbit