Skip to content

[rhaiis] Enable profiler - #276

Merged
Harshith-umesh merged 1 commit into
openshift-psap:mainfrom
ssaketh-ch:profiler-enabled
Sep 28, 2026
Merged

Harshith-umesh merged 1 commit into
openshift-psap:mainfrom
ssaketh-ch:profiler-enabled

Conversation

@ssaketh-ch

@ssaketh-ch ssaketh-ch commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Enable rhaiis.profiler.enabled.

Motivation

  • Turn on profiler collection for RHAIIS MI355x CPT runs.

Summary by CodeRabbit

  • Updates
    • Profiler collection is now enabled for the cpt-rhaiis-3.6-mi355x pipeline. Pipeline runs will therefore have profiling enabled, rather than disabled, so profiling information can be available for those runs. This change applies to that pipeline’s configuration; other pipelines are not indicated as changed.

@openshift-ci

openshift-ci Bot commented Sep 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign albertoperdomo2 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5d2eb8e7-c72b-4937-86ba-346ab792febb

📥 Commits

Reviewing files that changed from the base of the PR and between 4c2472a and 91b0953.

📒 Files selected for processing (1)
  • projects/rhaiis/orchestration/cpt.d/cpt.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The MI355X pipeline now sets rhaiis.profiler.enabled to true instead of false.

Changes

MI355X profiler setting

Layer / File(s) Summary
Update profiler setting
projects/rhaiis/orchestration/cpt.d/cpt.yaml
The MI355X pipeline sets rhaiis.profiler.enabled to true.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested reviewers: harshith-umesh

Merge Risk: ⚪ Minimal · up to 91b09

The MI355X CPT pipeline will collect profiler data as intended. No concrete merge-blocking risk is evident in the supplied change.

Architecture Summary

Architecture risk: 🔵 Low · up to 91b09

The change affects 1 system.

Changed systems: projects

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — projects (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in projects/rhaiis/orchestration/cpt.d/cpt.yaml: The MI355X pipeline changes rhaiis.profiler.enabled from false to true.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling the RHAIIS profiler.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-psap openshift-psap deleted a comment from coderabbitai Bot Sep 28, 2026
@openshift-psap openshift-psap deleted a comment from coderabbitai Bot Sep 28, 2026
@Harshith-umesh
Harshith-umesh merged commit 67c0558 into openshift-psap:main Sep 28, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants