[rhaiis] Add MI355X supplemental group to predictor

[ssaketh-ch]

Summary

• Pass the MI355X supplemental group to the shared predictor pod.

Motivation

• Allow MI355X predictor pods to access the shared model PVC.

Summary by CodeRabbit

• New Features
  • Inference workloads can now be assigned additional group permissions through deployment configuration. When no groups are configured, workloads retain their existing behavior.
  • The mi355x cluster preset now configures an additional group for inference workloads.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cb8e7685-280f-4977-b469-452c48a3b585

📥 Commits

Reviewing files that changed from the base of the PR and between 96eaefd and 25229d0.

📒 Files selected for processing (4)

• projects/rhaiis/orchestration/config.d/rhaiis.yaml
• projects/rhaiis/orchestration/manifests.py
• projects/rhaiis/orchestration/presets.d/clusters.yaml
• projects/rhaiis/orchestration/test_phase.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The deployment configuration now supports optional supplemental group IDs. The InferenceService manifest builder adds configured IDs to the predictor security context when the list is non-empty.

Changes

Supplemental group configuration

Layer / File(s)	Summary
Configure and pass supplemental groups projects/rhaiis/orchestration/config.d/rhaiis.yaml, projects/rhaiis/orchestration/presets.d/clusters.yaml, projects/rhaiis/orchestration/test_phase.py	The deploy configuration defaults supplemental_groups to an empty list. The mi355x preset sets it to [1000790000]. The test phase passes the configured value to the manifest builder.
Add groups to predictor security context projects/rhaiis/orchestration/manifests.py	build_inferenceservice accepts optional supplemental group IDs. When the list is non-empty, the predictor receives them as securityContext.supplementalGroups.

Priority: ⚪ Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: harshith-umesh

Merge Risk: ⚪ Minimal · up to 25229

The MI355X predictor receives the configured supplemental group, and no material merge risk is established. Proceed with normal checks.

Architecture Summary

Architecture risk: 🟡 Medium · up to 25229

The change affects 1 system.

Changed systems: projects

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — projects (service) was modified; 4 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in projects/rhaiis/orchestration/config.d/rhaiis.yaml: Adds supplemental_groups to deploy, defaulting to an empty list.
• observed — Modified behavior in projects/rhaiis/orchestration/manifests.py: build_inferenceservice adds the optional supplemental_groups parameter, typed as a list of integers or None.
• observed — Modified behavior in projects/rhaiis/orchestration/manifests.py: When supplemental_groups is non-empty, the predictor now receives a securityContext containing those supplementalGroups.
• observed — Modified behavior in projects/rhaiis/orchestration/presets.d/clusters.yaml: The mi355x preset adds supplemental group ID 1000790000.

Reliability and maintainability

• inferred — Risk-relevant change factors for projects: blast_radius_1; direct_dependents_1

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (2 skipped: 2…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding the MI355X supplemental group to the predictor.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (2 skipped: 2 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harshith-umesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Harshith-umesh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment