Add Helm 3 CLI download links alongside Helm 4#1197
Conversation
Helm 3 remains available for existing workflows. This adds a separate ConsoleCLIDownload resource so both versions appear on the CLI downloads page. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Skipping CI for Draft Pull Request. |
WalkthroughAdds a ChangesHelm 3 CLI download
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
webbnh
left a comment
There was a problem hiding this comment.
This looks OK to me, but I've got a suggestion, a question, and a proposed revision (I'll let you guess which is which 😉).
/lgtm
| @@ -16,3 +16,22 @@ spec: | |||
| links: | |||
| - href: 'https://mirror.openshift.com/pub/cgw/helm/4.1.4' | |||
There was a problem hiding this comment.
Consider updating this to 4.2.3.
(Presumably, this would be better done in a separate PR, but the additional hassle doesn't seem worthwhile, given the narrow scope and low complexity of this PR.)
| Helm 3 is a package manager for Kubernetes that simplifies deploying and managing | ||
| applications using Helm Charts. Helm 3 remains available for existing workflows. |
There was a problem hiding this comment.
Just out of curiosity, why does the first sentence use verbiage different from the Helm 4 text?
Regardless, given that we're including that second sentence, we might want to go all-in and say something like "Helm 3 continues to be provided for operational continuity, but it will not be compatible with future releases of OCP and so customers are encouraged to upgrade to Helm 4." (I suggest conferring with Marina and Jocelyn on detailed content and wording.)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sowmya-sl, webbnh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Helm 3 remains available for existing workflows. This adds a separate ConsoleCLIDownload resource so both versions appear on the CLI downloads page.
Reviewers and assignees:
Summary by CodeRabbit