Skip to content

Add Helm 3 CLI download links alongside Helm 4#1197

Draft
sowmya-sl wants to merge 1 commit into
openshift:mainfrom
sowmya-sl:helm-ocp-5-rel
Draft

Add Helm 3 CLI download links alongside Helm 4#1197
sowmya-sl wants to merge 1 commit into
openshift:mainfrom
sowmya-sl:helm-ocp-5-rel

Conversation

@sowmya-sl

@sowmya-sl sowmya-sl commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Helm 3 remains available for existing workflows. This adds a separate ConsoleCLIDownload resource so both versions appear on the CLI downloads page.

image

Reviewers and assignees:

Summary by CodeRabbit

  • New Features
    • Added Helm 3 CLI download information, including metadata and a link to the latest client bundle.

Helm 3 remains available for existing workflows. This adds a
separate ConsoleCLIDownload resource so both versions appear
on the CLI downloads page.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2026
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Walkthrough

Adds a ConsoleCLIDownload resource for Helm 3, including Helm-specific metadata and a link to the latest client bundle on the OpenShift mirror.

Changes

Helm 3 CLI download

Layer / File(s) Summary
Helm 3 download resource
manifests/07-downloads-helm.yaml
Adds the helm3-download-links ConsoleCLIDownload resource with Helm 3 description, display name, and latest client bundle URL.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too sparse and is missing required template sections like analysis, test setup, test cases, and browser conformance. Fill in the template sections with root cause/analysis, solution details, test setup, test cases, browser conformance, additional info, and reviewers/assignees.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a manifest changed; no test files or Ginkgo titles were added or modified.
Test Structure And Quality ✅ Passed PR only changes a Helm manifest; no Ginkgo test code was added or modified, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed Only a manifest changed; no new Ginkgo e2e tests were added, so the MicroShift check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only manifests/07-downloads-helm.yaml changed; no new Ginkgo tests or node-topology assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only a ConsoleCLIDownload manifest was added; no pods, replicas, affinity, node selectors, or PDBs were introduced.
Ote Binary Stdout Contract ✅ Passed Only a YAML manifest changed; no process-level code or stdout-producing entrypoints were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds a manifest entry for Helm CLI downloads; no new Ginkgo e2e tests or network-sensitive test code was introduced.
No-Weak-Crypto ✅ Passed Changed manifest only adds Helm CLI download metadata/URLs; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto/comparison logic found.
Container-Privileges ✅ Passed The only changed manifest is ConsoleCLIDownload resources; it contains no pod spec or privilege-related fields like privileged, hostPID, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds a YAML ConsoleCLIDownload manifest; it contains no logging code or sensitive data exposure.
Title check ✅ Passed The title clearly states the main change: adding Helm 3 CLI download links alongside Helm 4.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@webbnh webbnh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, but I've got a suggestion, a question, and a proposed revision (I'll let you guess which is which 😉).

/lgtm

@@ -16,3 +16,22 @@ spec:
links:
- href: 'https://mirror.openshift.com/pub/cgw/helm/4.1.4'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating this to 4.2.3.

(Presumably, this would be better done in a separate PR, but the additional hassle doesn't seem worthwhile, given the narrow scope and low complexity of this PR.)

Comment on lines +32 to +33
Helm 3 is a package manager for Kubernetes that simplifies deploying and managing
applications using Helm Charts. Helm 3 remains available for existing workflows.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, why does the first sentence use verbiage different from the Helm 4 text?

Regardless, given that we're including that second sentence, we might want to go all-in and say something like "Helm 3 continues to be provided for operational continuity, but it will not be compatible with future releases of OCP and so customers are encouraged to upgrade to Helm 4." (I suggest conferring with Marina and Jocelyn on detailed content and wording.)

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sowmya-sl, webbnh
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants