Skip to content

chore: remove unused Prioritize workflow - #350

Open
samanthajayasinghe wants to merge 1 commit into
openshift:masterfrom
samanthajayasinghe:chore/remove-prioritize-workflow
Open

chore: remove unused Prioritize workflow#350
samanthajayasinghe wants to merge 1 commit into
openshift:masterfrom
samanthajayasinghe:chore/remove-prioritize-workflow

Conversation

@samanthajayasinghe

@samanthajayasinghe samanthajayasinghe commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

What

Removes .github/workflows/prioritize.yml.

Why

The Prioritize workflow (RICE scoring via GitHub Projects V2) is a standalone workflow_dispatch entrypoint. It is not part of the fullsend poll/dispatch chain (fullsend-poll-jira.yaml / fullsend.yaml) and is not currently used by this repo, so it's being removed.

Notes

  • No other workflow or config references this file. The prioritize role remains listed in .fullsend/config.yaml roles:; it is harmless without the workflow and left in place to avoid unrelated churn — it can be dropped later if desired.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed the manual prioritization workflow.
    • Prioritization jobs can no longer be triggered through this workflow.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b3e44143-257d-4583-bb5d-91c516c21d0f

📥 Commits

Reviewing files that changed from the base of the PR and between 7d75dbb and 823538a.

📒 Files selected for processing (1)
  • .github/workflows/prioritize.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/prioritize.yml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

The .github/workflows/prioritize.yml workflow was deleted. This removes its manual dispatch inputs, concurrency settings, permissions, and Fullsend prioritization job.

Changes

Cohort / File(s) Summary
Workflow removal
.github/workflows/prioritize.yml
Deletes the Fullsend prioritization workflow and its GitHub Actions configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 82353

This change removes an unused manually triggered workflow without evidence of impact to the active automation chain; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the unused Prioritize workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request only deletes .github/workflows/prioritize.yml (50 lines). The deleted YAML contains no Ginkgo test declarations, and no test files or test titles changed. Therefore, it introd…
Test Structure And Quality ✅ Passed PASS: The pull request changes only .github/workflows/prioritize.yml, which it deletes. The commit contains no Go files, Ginkgo tests, or test-related paths. Therefore the listed Ginkgo test quality…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only .github/workflows/prioritize.yml, which it deletes. The parent-to-HEAD diff contains one deleted workflow and no added Ginkgo tests, Go files, or test paths. Ther…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS. The PR changes only .github/workflows/prioritize.yml, with 50 deletions. The deleted file is a GitHub Actions workflow and contains no Ginkgo tests. The PR adds or modifies no Go or test files…
Topology-Aware Scheduling Compatibility ✅ Passed PASS — The pull request changes only .github/workflows/prioritize.yml, deleting a GitHub Actions workflow. The exact commit diff contains no deployment manifest, operator, controller, or scheduling …
Ote Binary Stdout Contract ✅ Passed PASS: The pull request deletes only .github/workflows/prioritize.yml, a GitHub Actions YAML workflow. It does not change any OTE binary, main(), suite setup, or stdout behavior. The repository con…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request only deletes .github/workflows/prioritize.yml (1 file changed, 50 deletions). It adds no Ginkgo e2e tests and introduces no IPv4 assumptions or external connectivity require…
No-Weak-Crypto ✅ Passed PASS. The pull request only deletes .github/workflows/prioritize.yml (50 lines removed). The deleted workflow contains no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or secret/token co…
Container-Privileges ✅ Passed PASS. The pull request only deletes .github/workflows/prioritize.yml; it adds no container or Kubernetes manifest settings. The removed workflow contains no privileged: true, hostPID, `hostNetwo…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request only deletes .github/workflows/prioritize.yml (50 lines removed, no additions). The deleted workflow contains no direct logging commands or log-output expressions. It only pas…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request only deletes .github/workflows/prioritize.yml (50 lines). The deleted YAML contains no Ginkgo test declarations, and no test files or test titles changed. Therefore, it introduces no unstable or overly specific Ginkgo test name.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only .github/workflows/prioritize.yml, which it deletes. The commit contains no Go files, Ginkgo tests, or test-related paths. Therefore the listed Ginkgo test quality requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only .github/workflows/prioritize.yml, which it deletes. The parent-to-HEAD diff contains one deleted workflow and no added Ginkgo tests, Go files, or test paths. Therefore, the MicroShift test compatibility check is not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS. The PR changes only .github/workflows/prioritize.yml, with 50 deletions. The deleted file is a GitHub Actions workflow and contains no Ginkgo tests. The PR adds or modifies no Go or test files, so it introduces no SNO multi-node assumption.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS — The pull request changes only .github/workflows/prioritize.yml, deleting a GitHub Actions workflow. The exact commit diff contains no deployment manifest, operator, controller, or scheduling configuration change. Therefore, it introduces no topology-dependent scheduling constraint covered by this check.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request deletes only .github/workflows/prioritize.yml, a GitHub Actions YAML workflow. It does not change any OTE binary, main(), suite setup, or stdout behavior. The repository contains pre-existing process-level stdout writes (main.go configures a logger with os.Stdout, and fips.go uses fmt.Println), but the pull request does not introduce or alter them. Therefore, the OTE Binary Stdout Contract has no pull-request-caused failure.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request only deletes .github/workflows/prioritize.yml (1 file changed, 50 deletions). It adds no Ginkgo e2e tests and introduces no IPv4 assumptions or external connectivity requirements. The remaining prioritize entry is only a role in .fullsend/config.yaml, which is outside this check.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request only deletes .github/workflows/prioritize.yml (50 lines removed). The deleted workflow contains no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or secret/token comparison logic. The repository-wide exact-term scan also found no listed weak-crypto usage. No failure condition was introduced.

Full details: Container-Privileges

Explanation

PASS. The pull request only deletes .github/workflows/prioritize.yml; it adds no container or Kubernetes manifest settings. The removed workflow contains no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, or root-user declaration. The current repository search also found no matching privileged settings.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request only deletes .github/workflows/prioritize.yml (50 lines removed, no additions). The deleted workflow contains no direct logging commands or log-output expressions. It only passed event_payload and configured secrets to a reusable workflow. Therefore, the pull request introduces no logging that can expose sensitive data.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: samanthajayasinghe
Once this PR has been reviewed and has the lgtm label, please assign typeid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:50 PM UTC · Completed 11:00 PM UTC

Commit: 823538a · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.19

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] .github/workflows/prioritize.yml — This PR modifies a file under the .github/ protected path (governance/infrastructure). The PR has no linked issue providing explicit authorization for this change. While the PR description explains the rationale (removing an unused standalone workflow_dispatch entrypoint not part of the fullsend poll/dispatch chain), protected-path changes require a linked tracking issue or explicit human maintainer approval for formal authorization.
    Remediation: Link a tracking issue that authorizes removal of this workflow, or obtain explicit human maintainer approval for the protected-path change.

Low

  • [stale-reference] .fullsend/config.yaml:17 — The prioritize role is listed in .fullsend/config.yaml at line 17, but the corresponding workflow (.github/workflows/prioritize.yml) is deleted in this PR. After merge, this entry will be orphaned. The PR author explicitly acknowledges this and chose to leave it to avoid unrelated churn. The entry is genuinely harmless — fullsend does not fail when a listed role lacks a corresponding workflow.
    Remediation: Remove - prioritize from the roles: list in .fullsend/config.yaml for consistency, or add a comment explaining why it is retained.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run

Review

Findings

High

  • [protected-path] .github/workflows/prioritize.yml — This PR modifies a file under the .github/ protected path (governance/infrastructure). The PR has no linked issue providing explicit authorization for this change. While the PR description explains the rationale (removing an unused standalone workflow_dispatch entrypoint not part of the fullsend poll/dispatch chain), protected-path changes require a linked tracking issue or explicit human maintainer approval for formal authorization.
    Remediation: Link a tracking issue that authorizes removal of this workflow, or obtain explicit human maintainer approval for the protected-path change.

Low

  • [stale-reference] .fullsend/config.yaml:17 — The prioritize role is still listed in .fullsend/config.yaml at line 17, but the corresponding workflow (.github/workflows/prioritize.yml) is deleted in this PR. This leaves an orphaned role entry in the config. The PR author explicitly acknowledges this and chose to leave it to avoid unrelated churn.
    Remediation: Remove - prioritize from the roles: list in .fullsend/config.yaml for consistency, or add a comment explaining why it is retained.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (2)

Review

Findings

High

  • [protected-path] .github/workflows/prioritize.yml — This PR modifies a file under the .github/ protected path (governance/infrastructure). The PR has no linked issue providing explicit authorization for this change. While the PR description explains the rationale (removing an unused standalone workflow_dispatch entrypoint not part of the fullsend poll/dispatch chain), protected-path changes require a linked tracking issue or explicit human maintainer approval for formal authorization.
    Remediation: Link a tracking issue that authorizes removal of this workflow, or obtain explicit human maintainer approval for the protected-path change.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

@codecov-commenter

codecov-commenter commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.39%. Comparing base (c507a0a) to head (c39e48c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files          23       23           
  Lines        1598     1598           
=======================================
  Hits         1045     1045           
  Misses        473      473           
  Partials       80       80           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samanthajayasinghe

Copy link
Copy Markdown
Contributor Author
/test lint

The Prioritize workflow (RICE scoring via GitHub Projects V2) is a
standalone workflow_dispatch entrypoint that is not part of the fullsend
poll/dispatch chain and is not currently used by this repo. Remove it.

The 'prioritize' role remains listed in .fullsend/config.yaml roles; it
is harmless without the workflow and left in place to avoid unrelated
churn.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@samanthajayasinghe
samanthajayasinghe force-pushed the chore/remove-prioritize-workflow branch from 823538a to c39e48c Compare September 2, 2026 06:17
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 2, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:19 AM UTC · Completed 6:32 AM UTC

Commit: c39e48c · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.81

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Sep 2, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 2, 2026

Copy link
Copy Markdown

Risk Assessment: low (1/5)

Details

Pure deletion of an unused CI workflow file with minimal blast radius; the only elevated signal is CI_WORKFLOW_CHANGED, but since the change is a removal with no replacement logic, overall risk is low. Re-review anchoring preserves prior score of 1 as signals are unchanged.

Previous run

Risk Assessment: low (1/5)

Details

Pure deletion of an unused CI workflow file with minimal blast radius; the only elevated signal is CI_WORKFLOW_CHANGED, but since the change is a removal with no replacement logic, overall risk is low.

fullsend-ai-review[bot]

This comment was marked as outdated.

@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@samanthajayasinghe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rosa-sts-e2e c39e48c link true /test rosa-sts-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@samanthajayasinghe

Copy link
Copy Markdown
Contributor Author

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 9, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:11 AM UTC · Completed 1:21 AM UTC

Commit: c39e48c · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.17

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/low PR risk: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants