ROSAENG-66692 | fix(build): emit legacy CDN archive names at build time

[olucasfreitas]

Summary

Content Gateway ignores filename: in the CDN RPA and publishes the basename of each source path. This change makes hack/build_cli.sh produce the legacy CDN archive names directly (rosa-linux.tar.gz, rosa-macosx.tar.gz, etc.) while keeping Go-native .zip names for the GitHub release lane.

• Maps each platform/arch to the legacy CDN tarball name
• Windows sources use rosa-windows*.tar.gz; CGW converts them to .zip on upload
• GitHub .zip artifacts remain rosa_${os}_${arch}.zip

Companion konflux-release-data MR updates CDN RPA source paths to match.

Test plan

• bash -n hack/build_cli.sh
• make rosa / pre-push checks passed locally
• After merge: rebuild v1.2.65 snapshot and re-run CDN lane
• Verify mirror.openshift.com/pub/cgw/rosa/1.2.65/rosa-linux.tar.gz after release

Related

• Konflux confirmed filename: is deprecated for CGW (Customer Portal/Pulp only)
• Depends on konflux-release-data MR for RPA source path update
• Separate from ROSAENG-66692 | feat: inject DefaultVersion from git tag at build time #3512 (version ldflags) and ROSAENG-66693 | ci: auto-bump DefaultVersion on master after release #3513 (auto-bump)

Summary by CodeRabbit

• Bug Fixes
  • Updated release tarball filenames to match legacy CDN naming conventions across supported operating system and architecture combinations.
  • ZIP archive filenames remain unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2ca80765-0f55-44fe-85f8-20510a778cfb

📥 Commits

Reviewing files that changed from the base of the PR and between 5d453ad and e399c6e.

📒 Files selected for processing (1)

• hack/build_cli.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The build script adds cdn_archive_name to map supported OS and architecture pairs to legacy CDN tarball names. Unknown pairs use a generic fallback name. Release tarballs use the mapped names. ZIP filenames remain rosa_<os>_<arch>.zip.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to e399c

The build naming update is ready to merge with no identified current risk.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the build fix and the main behavior change: emitting legacy CDN archive names. It follows the required ticket and type format.
Description check	✅ Passed	The description explains the problem, reason for the change, implementation, resulting behavior, related dependency, and test plan. It is mostly complete, although it does not use all template heading…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The authoritative diff changes only hack/build_cli.sh. It adds cdn_archive_name and changes archive output names. It does not add or modify Ginkgo tests or any It(), Describe(), `Context…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only hack/build_cli.sh. The diff adds a shell function and changes tarball naming; it contains no Ginkgo tests, It blocks, cluster operations, Eventually/`Consiste…
Microshift Test Compatibility	✅ Passed	The pull request changes only hack/build_cli.sh. The diff adds shell archive-naming logic and changes tarball output names. It adds no Go files, test files, Ginkgo constructs, or MicroShift-incompat…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The reviewed range changes only hack/build_cli.sh. The patch adds shell archive-name mapping and changes tarball output names; it adds no Ginkgo tests or other test code. Therefore, the SNO mu…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — The pull request changes only hack/build_cli.sh. The diff adds cdn_archive_name and changes tarball filenames; it does not add or modify deployment manifests, operators, controllers, replic…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes only hack/build_cli.sh; it does not change Go source, OTE binaries, main(), or Ginkgo suite setup. The added echo statements run inside cdn_archive_name and are …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes only hack/build_cli.sh. The diff adds cdn_archive_name() and changes archive naming. It adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements. …
No-Weak-Crypto	✅ Passed	The pull request changes only hack/build_cli.sh archive naming. Added code contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret/token comparison. The existing `sha256…
Container-Privileges	✅ Passed	PASS. The pull request changes only hack/build_cli.sh. It adds archive-name mapping and changes tarball output names. The patch adds no privileged, host namespace, SYS_ADMIN, or `allowPrivilegeE…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request does not introduce sensitive-data logging. The new function emits only fixed archive names, and its fallback uses the controlled OS and architecture values from `oses=(darwin linux wi…

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-cdn-legacy-archive-names

---

_{Comment @coderabbitai help to get the list of available commands.}

[jerichokeyne]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerichokeyne, olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jerichokeyne,olucasfreitas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment