Skip to content

Fix the crash on adding a touch - #183

Merged
elliottkember merged 2 commits into
masterfrom
elliott/fix-rn-0.86-touch-crash
Aug 5, 2026
Merged

Fix the crash on adding a touch#183
elliottkember merged 2 commits into
masterfrom
elliott/fix-rn-0.86-touch-crash

Conversation

@elliottkember

@elliottkember elliottkember commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Using value.push seems to break against the new React Native. This causes taps on the sheet to crash the app with this error:

image

This is because in Hermes some objects are extensible and some aren't. This seems to have changed in the updated version of Hermes. There are reports of the same error so this is not a new problem, just a new instance of it.

Replacing the line with touches.value = [...touches.value, touch]; seems to solve it perfect.y

Uncaught Error

cannot add a new property

Source:
/Users/elliott/Sites/diana/node_modules/@openspacelabs/react-native-zoomable-view/src/ReactNativeZoomableView.tsx (417:4)

Call Stack:
useLatestCallback$argument_0 (/Users/elliott/Sites/diana/node_modules/@openspacelabs/react-native-zoomable-view/src/ReactNativeZoomableView.tsx:417)
<global> (/Users/elliott/Sites/diana/node_modules/@openspacelabs/react-native-zoomable-view/src/hooks/useLatestCallback.ts:14)
_resolveAndHandleTap (/Users/elliott/Sites/diana/node_modules/@openspacelabs/react-native-zoomable-view/src/ReactNativeZoomableView.tsx:1171)

@elliottkember
elliottkember requested a review from RachitB11 August 5, 2026 01:15
@elliottkember
elliottkember merged commit dba7438 into master Aug 5, 2026
1 check passed
@elliottkember
elliottkember deleted the elliott/fix-rn-0.86-touch-crash branch August 5, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants