Skip to content

20260713_functional_test_update#4374

Merged
ngrozae merged 2 commits into
mainfrom
20260713_functional_test_update
Jul 14, 2026
Merged

20260713_functional_test_update#4374
ngrozae merged 2 commits into
mainfrom
20260713_functional_test_update

Conversation

@ngrozae

@ngrozae ngrozae commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

🛠 Summary

Update abstract model definition + update whitelist

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI review requested due to automatic review settings July 14, 2026 10:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the functional test model definitions to better handle diamond inheritance defaults, and expands the SDL library whitelist to include the OpenVINO NPU VM runtime library needed by newer OpenVINO NPU components.

Changes:

  • Add libopenvino_intel_npu_vm_runtime to the allowed library lists (Linux .so and Windows .dll) in the SDL whitelist.
  • Refactor the “diamond inheritance default fix-up” helper into the GenerativeModel base class and reuse it from GenerativeModelHuggingFace.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/sdl/whitelists.py Whitelists the OpenVINO NPU VM runtime library for Ubuntu and Windows.
tests/functional/models/models_generative.py Centralizes diamond-inheritance default restoration logic in GenerativeModel and applies it from HF-based generative models.

@porlows1 porlows1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ngrozae
ngrozae merged commit a538b30 into main Jul 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants