Repository navigation
Update makefile - #4235
Merged
andrey-churkin merged 17 commits intoOct 5, 2026
Merged
Update makefile#4235
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved moderate findings affect dependency installation, test execution, reproducibility, and macOS worker usage.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
This pull request updates Makefile commands and refactors CI workflows to use shared commands and matrix-based jobs.
Changes:
- Adds backend-specific installation and test targets.
- Adds
pytest-xdisttooling. - Consolidates Linux, Windows, and macOS workflows into matrices.
- Uses Makefile targets for documentation and lint workflows.
| File | Reviewed changes |
|---|---|
tests/tools/requirements.txt |
Adds parallel pytest support. |
Makefile |
Defines installation, testing, and linting commands. |
.github/workflows/pre_commit_linters.yml |
Uses Makefile lint targets. |
.github/workflows/macos.yml |
Uses a macOS test matrix. |
.github/workflows/check_documentation.yml |
Uses Makefile documentation targets. |
.github/workflows/call_precommit.yml |
Uses a Linux test matrix. |
.github/workflows/call_precommit_windows.yml |
Uses a Windows test matrix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ifdef WEEKLY_MODELS | ||
| WEEKLY_MODELS_ARG := --weekly-models $(WEEKLY_MODELS) | ||
| endif | ||
| ARGS := $(wordlist 2, $(words $(MAKECMDGOALS)), $(MAKECMDGOALS)) |
Collaborator
Author
There was a problem hiding this comment.
make test-common -- -k test_example
Use -- to pass extra arguments
andrey-churkin
approved these changes
Oct 5, 2026
AlexanderDokuchaev
added a commit
to AlexanderDokuchaev/nncf
that referenced
this pull request
Oct 12, 2026
### Changes Update makefile: - remove unused comands - add actual commands and use them in workflows Update workflows: - use make commands - group jobs in matrix ### Reason for changes Outdate makefile ### Related tickets ### Tests https://github.com/openvinotoolkit/nncf/actions/runs/36149075137?pr=4235 https://github.com/openvinotoolkit/nncf/actions/runs/36149075404?pr=4235
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Update makefile:
Update workflows:
Reason for changes
Outdate makefile
Related tickets
Tests
https://github.com/openvinotoolkit/nncf/actions/runs/36149075137?pr=4235
https://github.com/openvinotoolkit/nncf/actions/runs/36149075404?pr=4235