Repository navigation
[ONNX] Fix the incorrect scale shape for the Conv layer when grouping is disabled - #4265
Merged
andrey-churkin merged 5 commits intoOct 23, 2026
Merged
Conversation
anzr299
approved these changes
Oct 13, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The tuple annotation is inaccurate, and the Conv regression lacks automated coverage.
2 open findings
What changed in this PR
Fixes ONNX Conv weight compression by correctly squeezing all reduction axes when grouping is disabled.
Changes:
- Supports multi-axis scale and zero-point preprocessing.
- Passes complete reduction-axis tuples through transformation paths.
| File | Description |
|---|---|
src/nncf/quantization/algorithms/weight_compression/onnx_backend.py |
Corrects Conv scale shaping during ONNX dequantization. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
anzr299
self-requested a review
October 15, 2026 14:44
anzr299
reviewed
Oct 16, 2026
andrey-churkin
force-pushed
the
ac/cvs196586
branch
from
October 21, 2026 09:12
a07da21 to
ecd5d59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
Related tickets
Tests
Conformance WC - success