Repository navigation
[ONNX] Register ONNXReduceL2Metatype - #4286
Open
Daksha1611 wants to merge 1 commit into
Open
Daksha1611 wants to merge 1 commit into
Daksha1611 wants to merge 1 commit into
Conversation
ONNXReduceL2Metatype was missing the ONNX_OPERATION_METATYPES.register() decorator, so ReduceL2 nodes resolved to UnknownMetatype and were never quantized on the ONNX backend. The ReduceL2 entry in the transformer ignored metatypes was never applied either. Add a test that every metatype defined in onnx_metatypes.py is registered.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@ONNX_OPERATION_METATYPES.register()decorator toONNXReduceL2Metatype.test_all_onnx_metatypes_are_registered, which fails if any concrete metatype class defined inonnx_metatypes.pyis not in the registry.test_reduce_l2_metatype_mapping.Reason for changes
ReduceL2resolved toUnknownMetatype, so it was never quantized on the ONNX backend, unlike the OpenVINO and Torch backends and the HW configs. TheONNXReduceL2Metatypeentry in the transformer ignored metatypes (#1953) was also never applied.Related tickets
Closes #4285
Tests
tests/onnx/test_metatypes.py.ruff checkandruff format --checkpass on the changed files.tests/onnx/test_metatypes.pyrun locally.