Fix sort comparison type selection - #2995
Open
GodlyDonuts wants to merge 1 commit into
Open
Conversation
Choose TOTALORDER from the sort key type rather than any payload type. Add direct coverage for integer keys with float payloads and preserve total ordering for float keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TensorFlow's
tf.RandomShufflelowering exposed a mismatch increateSortOp: the helper compares only the first operand (the sort key), but selectedTOTALORDERwhen any payload type was floating-point. Withi32keys and anf32payload, that produces an invalid integer comparison.This change:
TOTALORDERonly when the first element type is floating-point;TOTALORDER.This is the upstream prerequisite for tensorflow/tensorflow#125279. The equivalent MHLO helper was corrected by openxla/xla#40531.
Tested:
bazel test //:stablehlo_ops_test --test_output=errors.