[#47] 개발 환경에서만 SwiftLint가 동작하도록 수정한다 - #48
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
이번 풀요청은 배포용 패키지 그래프에서 SwiftLint 의존성을 제거하여 패키지 사용자가 불필요한 린트 규칙을 상속받지 않도록 개선하고, 메인테이너의 로컬 개발 및 린트 실행을 위한 통합 호스트 앱인 NexaClient 예제를 추가하였습니다. 리뷰 피드백에서는 Xcode의 Build Phase Run Script가 제한된 PATH 환경 변수를 사용하므로, Apple Silicon Mac 환경에서 Homebrew로 설치된 swiftlint를 찾지 못해 빌드가 실패할 수 있는 문제를 지적하고 PATH 설정을 추가하도록 보완을 요청했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
Package.swift에서 SwiftLint plugin과 관련 dependency 제거Examples/NexaClientiOS app 추가로 maintainer 전용 lint 및 consumer integration 확인 경로 구성🔍 상세
Package.resolved에서 SwiftLintPlugins pin 제거Examples/NexaClient/NexaClient.xcodeproj추가NexaClienttarget build 시 repo 루트의.swiftlint.yml을 사용하는 script phase 구성NexaClientapp에서NXAPIClient, typed request builder, raw request builder를 실제 소비자 경로처럼 참조하도록 최소 integration host 구성📸 영상 / 이미지 (Optional)