[#43] 디바운스를 구현하여 서버 요청을 최소화한다 - #49
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
이번 PR은 성공한 비인증 GET 응답의 캐싱 및 동일 요청 병합을 위한 인메모리 캐시 기능(NXCache)을 도입합니다. 코드 리뷰 결과, NXResponseCacheStore에서 호출자 Task 취소 시 요청 병합이 깨지는 버그와 만료된 캐시가 누적되는 메모리 누수 문제가 발견되었습니다. 이를 해결하기 위해 비동기 Task 내부에서 성공/실패 처리를 수행하고 만료된 캐시를 명시적으로 제거하도록 개선을 요청했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
GET응답을 짧은 TTL 동안 재사용하는 memory cache 추가GET요청을 하나의 transport 호출로 처리하도록 구성🔍 상세
NXClientConfiguration(cache:)옵션 추가NXCache.disabled,NXCache.memory(ttl:)추가NXResponseCacheInterceptor,NXResponseCacheStore,NXRequestCacheKey추가GET, body 없음,.authorized()미사용, 성공 status code로 제한NXRequestBuilder.requestSpec내부 상태를private으로 변경README.md,README.ko.md에NXCache사용 방식 추가📸 영상 / 이미지 (Optional)