Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f61115004c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
401요청의 refreshTask단일화NXAPIClient값 복사본과NXRequestBuilder복사본의 refresh coordinator 공유nil결과·호출자 취소 회귀 검증README.md·README.ko.md동작 문서화🔍 상세
NXAuthTokenProvider공개 요구 사항과NXAuthInterceptor의 최대 한 번 재전송 계약 유지nil결과의 원래401보존, 호출자 취소 격리 검증NXAuthRefreshLog한 건과 refresh 시작 요청 식별자 기록검증
swift build통과swift test105개·24개 suite 통과swiftlint lint --config .swiftlint.yml0개 위반git diff --check origin/develop...HEAD통과📸 영상 / 이미지 (Optional)
flowchart LR request[authorized 요청] --> auth[NXAuthInterceptor] auth --> initial[기존 토큰 첫 전송] initial --> unauthorized[401 응답] unauthorized --> coordinator[NXAuthRefreshCoordinator] coordinator -->|생성 또는 대기| refreshTask[공유 refresh Task] refreshTask -->|갱신 호출| provider[NXAuthTokenProvider] provider -->|결과 전달| refreshTask refreshTask -->|결과 기록| logger[NXLogger] refreshTask -->|새 토큰| replay[한 번 재전송] refreshTask -->|nil 결과| original[원래 401 반환] replay --> success[정상 응답] unauthorized -. 직접 갱신 호출 .-> provider provider -. 요청별 결과 기록 .-> logger logger -. 재전송 연결 .-> replay provider -. nil 결과 .-> originalNXAuthRefreshCoordinator와 공유Task기반 현재 흐름NXAuthTokenProvider를 직접 호출하던 제거 경로