Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6dbc6a23f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
NXURLSessionTransport의URLSessionTaskMetrics를Sendablesnapshot으로 변환하고NXNetworkMetricsObserver에 비동기로 전달하는 전송 관측 경계 추가.🔍 상세
NXNetworkMetrics,NXNetworkTransactionMetrics,NXNetworkMetricsObserver공개 경계 추가NXURLSessionTransport(urlSession:metricsObserver:)의 기본 인수로 기존NXHTTPTransport와NXURLSessionTransport(urlSession:)호출 호환성 유지NXURLSessionTaskMetricsDelegate가 Foundation metrics를 값 source로 즉시 복사한 뒤 snapshot 변환NXHTTPTransport, cache hit, 기존 logger event 순서와 request result 유지README.md,README.ko.md의 사용법과 제약 범위 동등 갱신🔄 변경 흐름
flowchart LR transport[NXURLSessionTransport] session[URLSession] raw[NXRawResponse] delegate[NXURLSessionTaskMetricsDelegate] metrics[NXNetworkMetrics] observer[NXNetworkMetricsObserver] transport -. 제거된 기존 호출 .-> session transport -->|요청과 delegate 전달| session session -->|응답 반환| transport transport --> raw transport -->|observer 전달| delegate session -->|metrics callback| delegate delegate -->|Sendable snapshot| metrics metrics -->|비동기 record| observer