chore(deps-dev): bump typescript-eslint 8.18 → 8.65 - #213
Merged
Conversation
Takes the safe half of #176. That PR grouped typescript-eslint with @types/vscode ^1.85.0 → ^1.125.0, and the @types/vscode half fails the release gate added in #208: @types/vscode ^1.125.0 greater than engines.vscode ^1.85.0. Either upgrade engines.vscode or use an older @types/vscode version `vsce package` requires @types/vscode <= engines.vscode. Raising engines.vscode to ^1.125.0 to satisfy it would drop support for every VS Code from 1.85 through 1.124 — a product decision, not a dependency bump, and one with no upside since the extension uses no API newer than 1.85. @types/vscode should track the minimum supported VS Code, so it stays pinned. Verified with pnpm release:check, which is the gate #176 fails. - tsc -b --force, lint (--max-warnings=0), format:check: clean - 1033 tests across 8 packages: pass - pnpm release:check (build + VSIX package + release gate): pass Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the safe half of #176.
Why #176 can't merge as-is
Dependabot grouped two unrelated bumps.
typescript-eslintis fine.@types/vscode ^1.85.0 → ^1.125.0fails the release gate added in #208:vsce packageenforces@types/vscode <= engines.vscode. There are only two ways to satisfy it:engines.vscodeto^1.125.0— this drops support for every VS Code from 1.85 through 1.124. That's a product decision about minimum supported editor version, not a dependency bump, and there's no upside here: the extension uses no API newer than 1.85.@types/vscodepinned — which is also just the correct convention.@types/vscodeshould track the minimum VS Code you support, not the latest published. Dependabot bumping it in isolation is a known anti-pattern for exactly this reason.Option 2. So this PR takes
typescript-eslintand leaves@types/vscodealone.Worth noting the gate did its job — this incompatibility would have shipped silently before #208 added real VSIX packaging to CI, and surfaced as a broken release build instead.
Verification
tsc -b --force,pnpm lint(--max-warnings=0),pnpm format:check— cleanpnpm test— 1033 tests across 8 packages passpnpm release:check— passes, which is specifically the gate chore(deps-dev): Bump the typescript group across 1 directory with 2 updates #176 fails. That's the evidence that@types/vscodewas the sole blocker rather than the two bumps interacting.Resolves to
typescript-eslint@8.65.0. No new lint findings at--max-warnings=0.🤖 Generated with Claude Code