Add unit tests for osism/tasks thin task wrappers

[berendt]

Closes #2354

Summary

Adds a unit-test suite for the thin task wrappers in osism/tasks/{ansible,ceph,kolla,kubernetes,reconciler}.py. These modules are the Celery entry points that mostly delegate into the ansible runner, the Redis task locks, a subprocess call, and the task-output stream. The suite exercises that glue with every external effect mocked, so the tests need neither a broker nor a reachable Redis.

Change set

A single commit, 7d892fc Add unit tests for osism/tasks thin task wrappers, adds one new file:

• tests/unit/tasks/test_task_wrappers.py (535 lines)

The tests are grouped by concern:

• App config / queue routing — parametrized across the five modules: the default queue, module-pattern → queue routing, and that the tasks register under their explicit names.
• setup_periodic_tasks receivers — schedules when the Redis lock is acquired, skips when scheduling is disabled, skips when the lock is not acquired, and the no-op receiver.
• ansible task bodies — gather_facts delegates with defaults and forwards publish=False; run delegates with defaults, forwards its arguments, and aborts when the task lock is active; noop returns True.
• Worker run bodies — parametrized across kolla/kubernetes/ceph: delegates with defaults, forwards overrides, and aborts when the task lock is active.
• reconciler.run — aborts when the task lock is active, returns None when the lock is not acquired, publishes output, skips output when publishing is off, and warns when the lock was already released.
• run_on_change — returns None when the lock is not acquired, runs the script without publishing, and warns when the lock was already released.

Notes for the reviewer

• No production code is touched — this is a test-only change.
• Scope matches issue Unit tests for osism/tasks/{ansible,ceph,kolla,kubernetes,reconciler}.py — thin task wrappers #2354 exactly: the five named osism/tasks/* modules and their run/gather_facts/noop/run_on_change bodies plus the app config and periodic-task wiring. No divergence from the issue.

---

Implemented by planwerk-agent 4c14036 with Claude:claude-opus-4-8

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}