Fix YAML date coercion - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configuration reader parses
serverless-compose.ymlwith js-yaml's default schema, which resolves unquoted date-shaped scalars toDateobjects, so after JSON normalisation aparamsvalue such as2012-10-17reaches the service as--param key=2012-10-17T00:00:00.000Zand a date-shaped mapping key becomes a timezone-dependent string. The framework component parses the unquotedKey: Valuelines ofosls info --verbosethe same way, so a date-shaped stack output is rewritten before it is stored in state and substituted into dependent services. This adds a shared schema that drops implicit timestamp resolution while keeping an explicit!!timestamptag, mirroring oss-serverless/osls#441, and applies it at the configuration reader and the framework component's YAML loads, with tests for each. Fixes #50.