AO3-7457 Extract work blurb presenter#5911
Open
nateberkopec wants to merge 2 commits into
Open
Conversation
67154f8 to
6541bd0
Compare
nateberkopec
commented
Jun 29, 2026
| <% id = "blurb_#{collection_item.item_type}_#{collection_item.item_id}_#{collection_item.collection.name}" %> | ||
| <blockquote id="<%= id %>" class="<% if collection_item.item_type == 'Bookmark' %>bookmark <% else %>work <% end %> blurb toggled"> | ||
| <% if collection_item.item_type == 'Work' %> | ||
| <%= render "works/work_module", work: collection_item.item, is_unrevealed: false %> |
Contributor
Author
There was a problem hiding this comment.
Note: this is_unrevealed thing was a no-op.
Contributor
Author
|
Noticed a missing i18n, fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7457
Purpose
My end goal is to cache work blurbs, and to fetch them all in a single
MGETfor all relevant work blurbs.In order to do this, we need a single place where we can make all the following decisions:
The end goal is something that will look like:
... and that will Just Work, resulting in a single MGET cache call.
We can't do this without this presenter, primarily because of the mystery/non-mystery module distinction, which needs to be calculated on a per-work basis.
I also think this cleans up the code quite nicely:
collection:options got cleaned upReferences