Repository navigation
chore(harness): drop corvus-splunk from the dev-harness scope - #52
Merged
Merged
Conversation
corvus-splunk is a Splunk app (conf/XML/CSV), not a Python component. Its
harness could only parse its own files and cross-reference names — it proved
the app is self-consistent, not that Splunk accepts it, so the guard earned
nothing and the umbrella carried a sixth component for it.
- root Makefile: ALL loses corvus-splunk; the comment block now says it is out
of harness scope instead of listing it among the legacy guards
- ci-v2.yaml: the harness matrix is the five in-scope components
- delete corvus-splunk/{Makefile,validate.py,.gitignore} — harness files only
- docs/DEV-READINESS-REVIEW.md: the splunk rows and the umbrella paragraph say
out of harness scope, not "validates config"
The Splunk app itself (default/, lookups/, metadata/, bin/) is untouched.
Verified from this worktree: make cycle runs five components (v2, sdk, cli,
server, hooks) and exits 0; make lint/build/test/fix exit 0 and make fix is
idempotent; ci-v2.yaml parses with a 5-entry matrix; git diff --stat HEAD --
corvus-splunk/ shows only the three harness-file deletions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
corvus-splunkfrom the dev-harness scope entirely, per operator instruction.Makefile: dropped from theALLlist; the comment block no longer files it under the legacy guards.corvus-splunk/{Makefile,validate.py,.gitignore}.docs/DEV-READINESS-REVIEW.md: the splunk rows now say out of harness scope, not validates config.What was deliberately NOT touched
The Splunk app itself —
default/,lookups/,metadata/,bin/— is untouched. 16 app files remain tracked and byte-identical tobe0ba58. Only the harness entry and its three files are gone. If the intent was to delete the app too, that is a separate product decision and a separate PR.Verified
CI yaml parses; matrix is exactly
[corvus-v2, corvus-sdk, corvus-cli, corvus-server, corvus-hooks].make lint,build,test,fixall exit 0, andmake fixis idempotent (working-tree hash identical before and after).One thing worth knowing (pre-existing, not caused here)
Running
make cyclerewrites the committedcorvus-v2/coverage.jsonandcorvus-v2/junit.xml, becausemake testregenerates them and they are tracked. The branch was cleaned before commit, but anyone who runs the gate locally will see those two files dirty afterwards. That is a harness annoyance, not a regression — it is queued in the gap backlog rather than fixed here.Rollback
Revert the merge commit. The three deleted files return with it.