feat(deployments): switch ocis_full example to bind-mounted ./data/ volumes - #12801
Draft
LukasHirt wants to merge 1 commit into
Draft
feat(deployments): switch ocis_full example to bind-mounted ./data/ volumes#12801LukasHirt wants to merge 1 commit into
LukasHirt wants to merge 1 commit into
Conversation
…olumes Replace docker-managed named volumes with ./data/ bind mounts in the ocis_full deployment example so persisted data is directly accessible on the host, and add a migrate-volumes.sh helper to copy existing named-volume data across for upgrading deployments. Signed-off-by: Lukas Hirt <info@hirt.cz>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
FYI @mmattel I keep this now as a draft. It's quite a bigger change so I need to do some more testing first and also I do not want to merge this before the Saturdays workshop so that it does not break anything for that (and does not force updating the current slides/notes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ocis_fulldeployment example from docker-managed named volumes to./data/-relative bind mounts so persisted data is directly accessible on the hostmigrate-volumes.sh, a one-time helper that copies data from the old named volumes into the new bind-mount paths for existing deployments upgrading in placeTest plan
docker compose configvalidates cleanly for the full stack plus enabled web extensionsdocker compose upcreates and populates./data/*directories as expectedmigrate-volumes.shagainst a deployment with existing named volumes (includingocis-appsandcompanion-data) and confirm data lands in the correct./data/*pathsmigrate-volumes.shruns successfully under both bash 5.x and bash 3.2 (stock macOS/bin/bash)