Add write support for Internet Gateways - #3308
Draft
benjaminleonard wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
benjaminleonard
commented
Jul 28, 2026
| const routesTable = useReactTable({ | ||
| columns: useMemo( | ||
| () => [ | ||
| routeColHelper.accessor('router', { |
Contributor
Author
There was a problem hiding this comment.
Do we want to flip this and have the route first instead of the router?
Contributor
Author
|
More of an API design question. But how helpful is the name here in practice? I do wonder if the name of the attached item is sufficient. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously read-only. This adds the full write API.