Repository navigation
buildomat: publish macOS aarch64 binaries - #926
Merged
Conversation
sunshowers
added this pull request to stack #927
October 6, 2026 20:23
Contributor
Author
Revision history
Generated by jj-stack from this pull request's force-push history. |
sunshowers
force-pushed
the
jj-stack/buildomat-publish-macos-aarch64-mgd-and-ddmd-binaries-nmxkrxsl
branch
from
October 6, 2026 22:00
e28fa1c to
031da01
Compare
sunshowers
changed the title
Noticed while doing oxidecomputer/omicron#11417 that Omicron was building mgd and ddmd from scratch on macOS. Cache aarch64 binaries (presumably nobody is using x86_64 binaries?) by building them in GitHub Actions and having a Buildomat job pull from there. The `fetch-gh-artifacts.sh` script is copied verbatim from https://github.com/oxidecomputer/cockroach/blob/c6c314d6cfff4b51e1df3355cb72172e45150ceb/.github/buildomat/fetch-gh-artifacts.sh. The script is known to work well. Note that the script doesn't pass `shellcheck -o all` so we don't add it to the set of scripts to lint in the shellcheck job.
sunshowers
force-pushed
the
jj-stack/buildomat-publish-macos-aarch64-mgd-and-ddmd-binaries-nmxkrxsl
branch
from
October 6, 2026 22:02
031da01 to
756b2fe
Compare
taspelund
approved these changes
Oct 6, 2026
Contributor
Author
|
Tested in https://github.com/oxidecomputer/omicron/actions/runs/37540183776/job/112531015839?pr=11437 -- works great and brings the time down by around 15 minutes. I'll also port over Dendrite next which should bring the time down by another 10 minutes. |
sunshowers
deleted the
jj-stack/buildomat-publish-macos-aarch64-mgd-and-ddmd-binaries-nmxkrxsl
branch
October 6, 2026 22:53
This was referenced Oct 6, 2026
sunshowers
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 7, 2026
Pins maghemite to e28fa1c2, an earlier head of oxidecomputer/maghemite#926, which is the first commit with macos-aarch64 binaries. Generated by `tools/update_maghemite.sh -c e28fa1c2b6001aa6cace05eeb567a09491371ab0`. Redo against maghemite main once that PR merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while doing oxidecomputer/omicron#11417 that Omicron was building mgd and ddmd from scratch on macOS. Cache aarch64 binaries (presumably nobody is using x86_64 binaries?) by building them in GitHub Actions and having a Buildomat job pull from there.
The
fetch-gh-artifacts.shscript is copied verbatim from https://github.com/oxidecomputer/cockroach/blob/c6c314d6cfff4b51e1df3355cb72172e45150ceb/.github/buildomat/fetch-gh-artifacts.sh. The script is known to work well. Note that the script doesn't passshellcheck -o allso we don't add it to the set of scripts to lint in the shellcheck job.Also build the
admbinaries on macOS for parity with Linux, even though Omicron doesn't need them.