Fix: Delta should be chars count, not bytes len - #244
Merged
Conversation
adzialocha
force-pushed
the
adz/delta-index-bug
branch
3 times, most recently
from
August 23, 2026 15:22
fb8e599 to
7f6afbf
Compare
This fixes a bug where we've converted the Loro text deltas wrongly by using the bytes len of the inserted string instead of the number of characters. When inserting a non-ASCII character this would lead to a bytes len > 1, scrambling text documents. Co-authored-by: niklaswimmer <niklas@viric.eu>
Stay consistent with how GTK names char-based positioning. Co-authored-by: niklaswimmer <niklas@viric.eu>
adzialocha
force-pushed
the
adz/delta-index-bug
branch
from
August 23, 2026 21:03
7f6afbf to
36496dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where we've converted the Loro text deltas wrongly by using the bytes len of the inserted string instead of the number of characters.
When inserting a non-ASCII character this would lead to a bytes len > 1, scrambling text documents.