Skip to content

Fix: Correctly pop undo-redo cursor from LIFO vec #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adzialocha merged 1 commit into from
Aug 23, 2026
Merged

Fix: Correctly pop undo-redo cursor from LIFO vec #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions reflection-doc/src/document.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,8 @@ mod imp {
obj,
#[upgrade_or_default]
move |stack_type, _, _| {
// The `loro::UndoManager` holds internal locks, so we can't update the `Document.can_undo/can_redo` property inline
// The `loro::UndoManager` holds internal locks, so we can't update the
// `Document.can_undo/can_redo` property inline
obj.main_context().spawn(clone!(
#[weak]
obj,
Expand Down Expand Up @@ -589,10 +590,12 @@ mod imp {
#[weak]
obj,
move |_, _, mut meta| {
*obj.imp().final_insert_cursor.write().unwrap() =
// Popping from the Vec is LIFO, so we pop the selection bounds first and then
// the insert cursor (reverse of how they've been added)
*obj.imp().final_selection_bound.write().unwrap() =
meta.cursors.pop().map(|cursor| cursor.cursor);

*obj.imp().final_selection_bound.write().unwrap() =
*obj.imp().final_insert_cursor.write().unwrap() =
meta.cursors.pop().map(|cursor| cursor.cursor);
}
))));
Expand Down
Loading